fix(config): generate#976
Open
till wants to merge 1 commit intopaketo-buildpacks:mainfrom
Open
Conversation
don't overwrite nginx.conf if it already exists. this is an alternative to paketo-buildpacks#975 with the failure test case disabled as it shouldn't hit that anymore. the test kind of suggests that overwriting the nginx.conf is "okay", which I would argue is a bug. related: paketo-buildpacks#667
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
don't overwrite nginx.conf if it already exists.
this is an alternative to #975 with the failure test case disabled
as it shouldn't hit that anymore. the test kind of suggests that
overwriting the nginx.conf is "okay", which I would argue is a bug.
related: #667
Summary
Use Cases
Checklist