Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow up PR of the #1454
More specifically, the
setup.shscript, uses code that has the same functionality, as we already have for the rest of the buildpacks under the script repository. This PR, refactors thesetup.shscript and applies the same structure under theactions/tools/setupaction. This is useful, as having the same codebase structure accros implementations, is easier for the authors to understand and also, in case a change in one of the script has been made e.g. to fix a bug, is easier to apply to the rest of the scripts too, as they are exactly the same, which increases the maintenance of all the scripts in general.Use Cases
Checklist