The value of templateAlpha will be NaN if max is equal to min.#332
Open
TerminatorSd wants to merge 1 commit into
Open
The value of templateAlpha will be NaN if max is equal to min.#332TerminatorSd wants to merge 1 commit into
TerminatorSd wants to merge 1 commit into
Conversation
Actually NaN does not lead to a bug, cause I find something below about globalAlpha on MDN: "Values outside that range, including Infinity and NaN, will not be set, and globalAlpha will retain its previous value." And, of course. The default value is 1. However, I do not think it is a good idea to compare a number with NaN. Hope this commit will help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually NaN does not lead to a bug, cause I find something below about globalAlpha on MDN:
"Values outside that range, including Infinity and NaN, will not be set, and globalAlpha will retain its previous value."
And, of course. The default value is 1.
However, I do not think it is a good idea to compare a number with NaN.
Hope this commit will help.