Skip to content

Frontend cleanups#5585

Merged
ChrisDodd merged 2 commits intop4lang:mainfrom
ChrisDodd:cdodd-fecleanup
Apr 14, 2026
Merged

Frontend cleanups#5585
ChrisDodd merged 2 commits intop4lang:mainfrom
ChrisDodd:cdodd-fecleanup

Conversation

@ChrisDodd
Copy link
Copy Markdown
Contributor

@ChrisDodd ChrisDodd commented Apr 13, 2026

  • Clean up the creation of the P4Program object in the parser
  • Clean up DontcareArgs to not creating unnecessary copies.

@ChrisDodd
Clean up creation of P4Program in parser
8c347cd 
Signed-off-by: Chris Dodd <cdodd@nvidia.com>
@ChrisDodd
Avoid useless busy-work overhead in DontcareArgs
767053a 
Signed-off-by: Chris Dodd <cdodd@nvidia.com>
@ChrisDodd ChrisDodd requested review from fruffy and kfcripps April 13, 2026 21:15
kfcripps
kfcripps approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kfcripps kfcripps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisDodd ChrisDodd added this pull request to the merge queue Apr 14, 2026
Merged via the queue into p4lang:main with commit 54ec235 Apr 14, 2026
20 checks passed
@ChrisDodd ChrisDodd deleted the cdodd-fecleanup branch April 14, 2026 03:05
@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kfcripps kfcripps kfcripps approved these changes

@fruffy fruffy Awaiting requested review from fruffy

Assignees

No one assigned

Labels

core Topics concerning the core segments of the compiler (frontend, midend, parser)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrisDodd @kfcripps @fruffy