[P4Testgen]: Support action selectors and action profiles for P4Testgen v1model PTF tests#5544
[P4Testgen]: Support action selectors and action profiles for P4Testgen v1model PTF tests#5544
Conversation
|
If this thing converges to a solution on its own, that would be pleasantly surprising :-) |
The problem with the free tier is that it has a time limit. Our builds take a while and so it always terminates before doing anything. I'll play around with it a bit more to see whether I can find a functioning approach. |
d7393dc to
cb52da3
Compare
cb52da3 to
b870d72
Compare
|
@jafingerhut I had to hand this over to a local GPT 5.3 model. Unfortunately, the online Git models are a bit brain-damaged, because they have a limited time-budget and less context allowed, from what I can tell. Still, now we actually have action selector programming working for the PTF BMv2 framework. There is some question on the exact semantics for one-shot programming, I tried to follow the ones described here: https://p4lang.github.io/p4runtime/spec/main/P4Runtime-Spec.html#sec-oneshot Weight must be non-zero. Maybe we should make this configurable. |
|
Marking as breaking change because we change the base-test API. I can also split this out into a separate PR. |
Is there some benefit to allowing weights in one-shot action selector configuration to be 0? It is not clear to me what that might be. |
I have only skimmed through the base_test.py changes so far, but in every case I checked I saw only new optional parameters added to existing method calls. Is there an example of a change in that file you consider breaking? |
I went back and added Also |
jafingerhut
left a comment
There was a problem hiding this comment.
Looks reasonable to me, although I can't claim to have digested every line of change.
d37888e to
62e7002
Compare
…ck end. Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
…eights are positive. Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
62e7002 to
266c03c
Compare
Uh oh!
There was an error while loading. Please reload this page.