Setting specific priority queue depth or rate#566
Setting specific priority queue depth or rate#566edgar-costa wants to merge 1 commit intop4lang:mainfrom
Conversation
|
Hi, |
|
Hi Antonin, Either me or my organization are members of the p4.org. However I already contacted my University and we started the procedure from: https://p4.org/join/. What should I do once we are members? |
|
Once you are members, I will get notified (although you can also let me know when the procedure is done). I can then review your PR & merge it. |
|
Is the suuport for setting rate for priority queus available now? |
|
@sys-ptipu I am hoping by @'ing this Github id, a person respnosible for the (so far) three comments made recently will notice and respond. We would like to know how many PRs you plan to create such comments for in the future. If only three, no problem, but if all open PRs on repositories under https://github.com/p4lang, that would be a lot of "noise" in the PR comments, and it would be great if you might find a different way of recording this information. |
|
I believe that the original intent of this issue, which I believe was to enable setting the depth and rate of individual priority queues, might be implemented now? |
Add a method to set the depth or rate of priority queues in the simple switch. At the moment the
sswitch_CLI.pyis usingset_egress_queue_depth/rateto set the rate/depth of a given port but there was not way to set if for an individual priority queue.This patch adds:
set_egress_priority_queue_depth/ratein thesimple_switchimplementationthriftfilesdo_set_queue_depth/ratefromsswitch_CLI.pyso they call the new functions when a priority is provided. Also added exception catchers when the parameters are not integers.Update: I realized that this will not build if the
multiqueueingis not enabled at compile time. This is becauseQueueingLogicRLdoes not know about priorities. What would be the right way to proceed?