Add Bazel Build Support for simple_switch_grpc#1349
Add Bazel Build Support for simple_switch_grpc#1349Vineet1101 wants to merge 19 commits intop4lang:mainfrom
Conversation
Vineet1101
changed the title
Vineet1101
force-pushed
the
bazel-migration
branch
from
9b9a24e to
122e955
Compare
|
Can someone review this |
Vineet1101
force-pushed
the
bazel-migration
branch
from
d9ce630 to
1374b7c
Compare
|
@Vineet1101 Please add the Github workflow CI test to this PR to show correctness of the build solution as well as testing |
… of CPU port in switch log Signed-off-by: Vineet1101 <Vineetgoel692@gmail.com> Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Vineet1101
force-pushed
the
bazel-migration
branch
from
13bcc65 to
52018ae
Compare
|
@matthewtlam the signing key for the OpenSUSE-hosted p4lang package repo has expired. What should I do?? |
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com> Fix missing runner.h by exposing simple_switch headers fixed failing linking errors Signed-off-by: Vineet1101 <vineetgoel692@gmail.com> Apply successful pkgconfig_grpc linker fixes from testing branch
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Ignore that test failure, but do please pay attention to any other test failures that occur that are unrelated to that one, which I believe you have one on this PR at this time (in the CI test named "Bazel / build-and-test (pull_request)" |
Vineet1101
force-pushed
the
bazel-migration
branch
from
b41299e to
479cee2
Compare
|
|
||
| apt-get update | ||
| # Add p4lang repo with trusted=yes to bypass expired GPG key | ||
| echo 'deb [trusted=yes] http://download.opensuse.org/repositories/home:/p4lang/xUbuntu_22.04/ /' \ |
There was a problem hiding this comment.
for now I have added this code to pass this test if its not required I will remove it
|
@matthewtlam @smolkaj can you please review as it is passing all tests now and apologies for taking too many commits :) |
|
Hey @matthewtlam can you please review it |
|
Thanks for your PR @Vineet1101, it looks great. None of the PRs will be carefully reviewed until Apr 1 (once the contributor deadline is over). Starting today (March 16th), the GSoC contributor application will open. Please make sure you submit your application before the deadline. During the first week of April, after applications and PRs are reviewed, candidates who will be considered will be sent an interview. The contributor who gets admitted into GSoC will have their PR pushed to head |
|
ok @matthewtlam |
3 participants
This PR introduces support for building BMv2's
simple_switch_grpcand its associated libraries using Bazel (v8.5.0), modernizing the build system alongside the existing CMake configuration.Key Changes:
bzlmodfor dependencies likerules_ccandgoogletest.jsoncppandspdlog.src/BMI,src/bm_sim(with dynamicversion.cppgeneration), andtargets/simple_switch.PIsubmodule (bmpi) to link correctly against system-installed PI shared libraries (libpi.so,libpip4info.so, etc.).services/BUILD.bazelto leverage the system'sprotocandgrpc_cpp_plugin, ensuring strict ABI compatibility with the systempiandgrpc++libraries.simple_switch_grpcunit tests. Structured them withtags = ["exclusive"]to prevent execution overlap on the shared gRPC port (0.0.0.0:50056).