Cleanup GTests for simple_switch_grpc: remove global switch instance#1348
Open
p2peek wants to merge 4 commits intop4lang:mainfrom
Open
Cleanup GTests for simple_switch_grpc: remove global switch instance#1348p2peek wants to merge 4 commits intop4lang:mainfrom
p2peek wants to merge 4 commits intop4lang:mainfrom
Conversation
Signed-off-by: Prakash Kumar <kumarprakash3909@gmail.com> Signed-off-by: Prakash <prakash@prakash.localdomain>
p2peek
force-pushed
the
fix-simple-switch-grpc-tests
branch
10 times, most recently
from
60000e1 to
369a74b
Compare
Signed-off-by: Prakash <kumarprakash3909@gmail.com> Signed-off-by: Prakash <prakash@prakash.localdomain>
p2peek
force-pushed
the
fix-simple-switch-grpc-tests
branch
from
369a74b to
0eeb702
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #783
The current tests create a single SimpleSwitchGrpc instance shared across all tests through a global GoogleTest environment.
This can cause state to persist between tests (e.g. port operational status), which may lead to unrelated tests failing.
This change removes the global test environment so that tests no longer share a single switch instance, improving test isolation.