fix: strip query and fragment before finding matched tsconfig file#1081
fix: strip query and fragment before finding matched tsconfig file#1081sapphi-red wants to merge 1 commit intomainfrom
Conversation
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1081 +/- ##
==========================================
+ Coverage 92.35% 92.39% +0.04%
==========================================
Files 21 21
Lines 4079 4102 +23
==========================================
+ Hits 3767 3790 +23
Misses 312 312 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 9.19%
Performance Changes
Comparing Footnotes
|
eb92795 to
b6d6226
Compare
|
I'm aware of these PRs but will take some time to get through, it feels like we are accumulating slop. |

When
tsconfig: 'auto'is configured,find_tsconfig()receives the raw importer path from the caller. Vite plugins commonly append query parameters to real file paths (e.g.src/routes/index.tsx?custom=foo). This caused the path to not match the expected tsconfig files (vitejs/vite#21889).This PR fixes that by stripping query params and hash fragments from the importer path before finding the tsconfig.json that matches.