fix(file): display error message for multiple files - #857
Open
JacquesLarique wants to merge 1 commit into
Open
Conversation
MaximeBajeux
previously approved these changes
Sep 3, 2024
oalkabouss
previously approved these changes
Sep 3, 2024
anooparveti
requested changes
Sep 3, 2024
anooparveti
left a comment
anooparveti
left a comment
Contributor
There was a problem hiding this comment.
commit of the title can be display error message for multiple files
JacquesLarique
force-pushed
the
fix/MANAGER-15044
branch
from
September 4, 2024 15:31
b9c1877 to
cca01d1
Compare
JacquesLarique
changed the title
Contributor
Author
|
This fix is not correct I need to redo it This comment is no longer relevant. |
JacquesLarique
dismissed stale reviews from oalkabouss and MaximeBajeux
via
September 16, 2024 15:20
c494d4b
JacquesLarique
force-pushed
the
fix/MANAGER-15044
branch
from
September 16, 2024 15:20
cca01d1 to
c494d4b
Compare
ref: MANAGER-15044 Signed-off-by: Jacques Larique <jacques.larique.ext@ovhcloud.com>
JacquesLarique
force-pushed
the
fix/MANAGER-15044
branch
from
September 16, 2024 15:23
c494d4b to
3c10423
Compare
MaximeBajeux
approved these changes
Sep 16, 2024
anooparveti
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title of the Pull Requests
Fix File component extension error display
Description of the Change
Removed condition to display errors
Benefits
Better user experience by adding information regarding the invalid extension error for a file
Possible Drawbacks
Applicable Issues
When a user select a file with an invalid extension, the file appear in error but without any explanation as to why the file is invalid.