Deduplicate jsc bindings, runtime api, test matchers, and shell builtins#32023
Deduplicate jsc bindings, runtime api, test matchers, and shell builtins#32023alii wants to merge 4 commits into
Conversation
|
@robobun adopt |
|
Adopted. Fixed the rust build break in 35f1e9b (missing Two consecutive full CI runs (61682, 61749) are green on every job that ran on a healthy agent: 284/284 each, covering clippy, all build lanes, asan, linux, windows, musl, and darwin. The only red is two darwin tart VMs that degraded mid-run (both ended with the same VM termination hook error): they timed out after failing only environment-dependent tests (the init.test.ts CLAUDE.md runner-image issue, mysql2/local-sql/s3 service tests), and the sibling job on each of those same lanes passed the full suite. Nothing in either run traces to this diff. Verification details are in the PR description; ready for review. |
|
Updated 8:02 AM PT - Jun 10th, 2026
❌ @robobun, your commit 4a6537d has 5 failures in
🧪 To try this PR locally: bunx bun-pr 32023That installs a local version of the PR into your bun-32023 --bun |
What this does
The interlocked runtime cluster: ConsoleObject
TagResultrework shared with the macro evaluator and test-runner pretty printer;expect(...)matcher dedup (deletestoStrictEqual.rstwin); subprocessWritableextraction shared with shellsubproc; shell builtins'OutputTaskVTablemacro; URL moving to a re-export ofbun_url::whatwg::URLwith aUrlJscextension trait; deletion of the dead draft FFI implementation (~620 lines); cron/CryptoHasher/dns/valkey/CodeCoverage dedups. Net −5k lines.Stacked on the install-cli PR — merge order: foundations → install-cli → this. Split from #31912 (whole-repo simplification pass; closing that PR in favor of module-scoped splits). This PR only moves and removes code — zero intended behavior change.
Verification
URL::href_from_jscalled in fetch.rs without theUrlJsctrait in scope); fixed by importing the trait.cargo clippy --workspaceandrust:check-all(all 10 target configs) now pass.expect.test.js,toHaveReturnedWith), console formatting (table/iterator/inspect), shell (bunshell.test.ts, builtin commands), CryptoHasher/hash/csrf, macros, spawn IPC and streaming stdio, ServerWebSocket, UDP, cron, markdown, JSON5.