-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fetch: encode FetchTasklet's cross-thread ownership in the type system #31745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alii
wants to merge
20
commits into
main
Choose a base branch
from
ali/fetch-lifetime-clarity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
fa2e27a
threading: make GuardedLock \!Send/\!Sync like MutexGuard
alii 7934b18
fetch: make ignore_data atomic, mirror is_http2 for lock-free reads, …
alii 0093fb3
fetch: partition FetchTasklet into JsState and HttpHandoff (rename-only)
alii 561266a
fetch: start FetchTasklet refcount at 2 and name each ref release
alii fb8ad8a
fetch: document FetchTasklet's cross-thread ref and lock protocol
alii 92e88ed
fetch: convert FetchTasklet's mutex to Guarded<HttpHandoff> with spli…
alii b21b592
fetch: make Weak::create_ptr unsafe so callers must prove ctx liveness
alii 92ec278
Merge origin/main (resolve TODO-sweep conflicts in FetchTasklet.rs)
robobun 08158a0
fetch: cover process.exit() with in-flight requests (release_at_shutd…
robobun bee55b6
fetch: balance streaming-upload refs in release_at_shutdown
robobun eab71d3
[autofix.ci] apply automated fixes
autofix-ci[bot] 2ceb902
test: drop stale ASAN stderr filter in fetch-exit-in-flight
robobun 0d2ddc2
fetch: balance sink/drain refs in callback's shutdown branch too
robobun 2bb34e8
fetch: take streaming-upload exit refs atomically across all three paths
robobun a09b295
test: document why fetch-exit-in-flight overrides the default timeout
robobun 4722a5a
ci: retrigger
robobun cbd7951
Merge branch 'main' into ali/fetch-lifetime-clarity
alii e6abfab
fetch: take streaming exit refs in on_progress_update's shutdown path…
robobun acde789
fetch: claim streaming-upload ref releases against exit-window takes
alii e1254e6
test: suppress macOS ParkingLot one-time leak in exit-in-flight tests
alii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.