bake: fix dev server crashes in SCB dependency tracing and route syntax error reporting#31697
Open
robobun wants to merge 6 commits into
Open
bake: fix dev server crashes in SCB dependency tracing and route syntax error reporting#31697robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Jun 7, 2026 in 10m 59s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/bake/FrameworkRouter.rs:1696-1705 |
Comments contain bug-history narrative (CLAUDE.md convention) |
Annotations
Check warning on line 1705 in src/runtime/bake/FrameworkRouter.rs
claude / Claude Code Review
Comments contain bug-history narrative (CLAUDE.md convention)
nit: per root CLAUDE.md ("Comments carry only durable non-obvious content … no bug history, no 'we use X because Y was broken' — that belongs in the PR description"), the past-tense crash narrative here ("previously made `TinyLog::print` slice `rel_path[u32::MAX..]` and crash the dev server") and the freed-memory-reuse middle of the DevServer.rs:4506-4513 comment ("the push reallocates the buffer and the stale iterator walks freed memory … producing garbage file indexes that crash `trace_depende
Loading