-
Notifications
You must be signed in to change notification settings - Fork 4.7k
cli: add --check flag to syntax-check a file without executing
#30981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robobun
wants to merge
17
commits into
main
Choose a base branch
from
farm/e67ccbc8/add-check-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
649eb89
cli: add --check flag to syntax-check a file without executing
robobun 7e317c8
[autofix.ci] apply automated fixes
autofix-ci[bot] 39a0860
cli: reject --check with empty --eval/--print too
robobun b07beff
address review: describe.concurrent + move zsh completion to run
robobun b62cd69
test: assert exitCode last; use test.each for --eval/--print variants
robobun 913e7d9
test: assert exact exit code 9 for --check + --eval/--print conflict
robobun 6ec8763
cli: treat `bun --check -` as stdin, matching `node --check -` and `b…
robobun d3374df
cli: don't strip 'run' positional under node-argv0 in --check
robobun ad690f9
cli: dispatch --check before --parallel/--filter/--workspaces
robobun bfbba29
ci: retrigger
robobun f954a68
docs: add --check to run.mdx; test: move not.toContain before toBe
robobun 4508873
[autofix.ci] apply automated fixes
autofix-ci[bot] 11203f8
cli: honor --if-present in --check when the entry point is missing
robobun d33d2eb
test: assert exact exit code 1 for missing file in --check
robobun cf293a0
cli: cursor-read --check entry so pipes passed as paths work
robobun c30f87d
cli: honor --loader overrides in --check
robobun afe44fc
cli: say 'Cannot read' for non-ENOENT --check entry failures
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,219 @@ | ||
| import { describe, expect, test } from "bun:test"; | ||
| import { bunEnv, bunExe, tempDir } from "harness"; | ||
|
|
||
| describe.concurrent("bun --check", () => { | ||
| test("exits 0 and produces no output for a syntactically valid file", async () => { | ||
| using dir = tempDir("check-valid", { | ||
| "ok.js": `const x = 1;\nconsole.log("SHOULD NOT RUN");\n`, | ||
| }); | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check", "ok.js"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| // The script must not execute. | ||
| expect(stdout).not.toContain("SHOULD NOT RUN"); | ||
| expect(stdout).toBe(""); | ||
| expect(stderr).toBe(""); | ||
|
robobun marked this conversation as resolved.
|
||
| expect(exitCode).toBe(0); | ||
| }); | ||
|
|
||
| test("exits 1 and reports a syntax error for an invalid file", async () => { | ||
| using dir = tempDir("check-invalid", { | ||
| "bad.js": `const x = ;\n`, | ||
| }); | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check", "bad.js"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toContain("error"); | ||
| expect(stderr).toContain("bad.js"); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(1); | ||
| }); | ||
|
|
||
| test("does not execute the file", async () => { | ||
| using dir = tempDir("check-noexec", { | ||
| "side-effect.js": ` | ||
| import fs from "node:fs"; | ||
| fs.writeFileSync("ran.txt", "1"); | ||
| process.exit(42); | ||
| `, | ||
| }); | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check", "side-effect.js"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toBe(""); | ||
| expect(stdout).toBe(""); | ||
| expect(await Bun.file(`${dir}/ran.txt`).exists()).toBe(false); | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| expect(exitCode).toBe(0); | ||
| }); | ||
|
|
||
| test("accepts TypeScript syntax in .ts files", async () => { | ||
| using dir = tempDir("check-ts", { | ||
| "ok.ts": `interface Foo { x: number }\nconst y: Foo = { x: 1 };\nexport { y };\n`, | ||
| }); | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check", "ok.ts"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toBe(""); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(0); | ||
| }); | ||
|
|
||
| test("accepts ESM import/export syntax", async () => { | ||
| using dir = tempDir("check-esm", { | ||
| "esm.mjs": `import foo from "bar";\nexport const x = 1;\n`, | ||
| }); | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check", "esm.mjs"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toBe(""); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(0); | ||
| }); | ||
|
|
||
| test("accepts top-level await", async () => { | ||
| using dir = tempDir("check-tla", { | ||
| "tla.js": `const x = await Promise.resolve(1);\n`, | ||
| }); | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check", "tla.js"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toBe(""); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(0); | ||
| }); | ||
|
|
||
| test("reads from stdin when no file is given", async () => { | ||
| { | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check"], | ||
| env: bunEnv, | ||
| stdin: new Blob(["let x = 1;\n"]), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toBe(""); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(0); | ||
| } | ||
| { | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check"], | ||
| env: bunEnv, | ||
| stdin: new Blob(["const x = ;\n"]), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toContain("error"); | ||
| expect(stderr).toContain("[stdin]"); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(1); | ||
| } | ||
| }); | ||
|
|
||
| test("reads from stdin when the positional is `-`", async () => { | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check", "-"], | ||
| env: bunEnv, | ||
| stdin: new Blob(["let x = 1;\n"]), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toBe(""); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(0); | ||
| }); | ||
|
|
||
| test("exits 1 when the file does not exist", async () => { | ||
| using dir = tempDir("check-missing", {}); | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check", "nope.js"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toContain("error"); | ||
| expect(stderr).toContain("nope.js"); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(1); | ||
| }); | ||
|
|
||
| test("exits 0 when the file does not exist and --if-present is set", async () => { | ||
| using dir = tempDir("check-if-present", {}); | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check", "--if-present", "nope.js"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toBe(""); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(0); | ||
| }); | ||
|
|
||
| test.each(["-e", "--eval", "-p", "--print"])("rejects combining --check with %s", async flag => { | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "--check", flag, "1 + 1"], | ||
| env: bunEnv, | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr.toLowerCase()).toContain("either --check or --eval"); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(9); | ||
| }); | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| test("works via `bun run --check <file>`", async () => { | ||
| using dir = tempDir("check-run", { | ||
| "bad.js": `function f( {\n`, | ||
| }); | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "run", "--check", "bad.js"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stderr).toContain("error"); | ||
| expect(stdout).toBe(""); | ||
| expect(exitCode).toBe(1); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.