fix(bake): validate app.bundlerOptions values are objects#30653
Closed
robobun wants to merge 1 commit into
Closed
Claude / Claude Code Review
completed
May 14, 2026 in 18m 46s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/http/bun-serve-args.test.ts:686-691 |
Ineffective .not.toThrow('reached unreachable code') assertion |
Annotations
Check warning on line 691 in test/js/bun/http/bun-serve-args.test.ts
claude / Claude Code Review
Ineffective .not.toThrow('reached unreachable code') assertion
This assertion is ineffective: `.not.toThrow("reached unreachable code")` passes when a *different* error is thrown, and this config (missing `framework`) will throw `'app' is missing 'framework'` right after bundlerOptions parsing — so the test passes for the wrong reason and would still pass if the `minify: false` fix were reverted. CLAUDE.md also explicitly forbids tests that check for absence of panic messages. Assert the expected error instead, e.g. `.toThrow("'app' is missing 'framework'")
Loading