bake: validate app.bundlerOptions and its subfields are objects#30409
Closed
robobun wants to merge 1 commit into
Closed
bake: validate app.bundlerOptions and its subfields are objects#30409robobun wants to merge 1 commit into
app.bundlerOptions and its subfields are objects#30409robobun wants to merge 1 commit into
Claude / Claude Code Review
completed
May 8, 2026 in 19m 43s
Code review found 1 important issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/bake/bake.zig:230-237 |
minify: false does not disable minification in production |
Annotations
Check failure on line 237 in src/bake/bake.zig
claude / Claude Code Review
minify: false does not disable minification in production
When `minify` is the boolean `false`, this enters the `isBoolean()` branch, skips the inner `if (asBoolean())` block, and breaks with `minify_syntax`/`minify_identifiers`/`minify_whitespace` still `null` — so in production (`bake.zig:792-794` does `orelse (mode != .development)`) an explicit `minify: false` is silently ignored and minification stays on. This is technically pre-existing release-build behavior, but since this PR is rewriting these exact lines to "fix the minify handling" it's the
Loading