http: fix use-after-free in onHandshake when checkServerIdentity rejects (u9sf0l)#29829
Merged
Merged
Claude / Claude Code Review
completed
Apr 28, 2026 in 15m 20s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/http/node-https-checkServerIdentity.test.ts:27 |
Use describe.concurrent for independent subprocess tests |
Annotations
Check warning on line 27 in test/js/node/http/node-https-checkServerIdentity.test.ts
claude / Claude Code Review
Use describe.concurrent for independent subprocess tests
nit: per `test/CLAUDE.md`, tests that each spawn an independent subprocess should use `describe.concurrent`. All four tests here spawn isolated `bunExe()` children with `port: 0` and no shared state, so this block can be `describe.concurrent("https.request checkServerIdentity", …)` to run them in parallel.
Loading