Skip to content
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
53d002c
feat: access providers in same scope
nank1ro Dec 9, 2025
aa4d153
refactor
nank1ro Dec 9, 2025
11fe9ea
fix: tests
nank1ro Dec 9, 2025
57ff372
fix: typos
nank1ro Dec 9, 2025
a654085
coverage: ignore coverage for unreachable states
nank1ro Dec 9, 2025
15586f3
coverage: ignore line
nank1ro Dec 9, 2025
05957a1
chore: fix typo
nank1ro Dec 9, 2025
012b870
refactor: use smaller methods\
nank1ro Dec 9, 2025
6d02e04
chore: coverage ignore indentation
nank1ro Dec 9, 2025
ad3f27f
docs: update dependencies
nank1ro Dec 9, 2025
f753a42
docs: update
nank1ro Dec 9, 2025
083f710
perf: optimize ProviderScope with zero-cost debug validation (#34)
Copilot Dec 10, 2025
e848f11
refactors
nank1ro Dec 11, 2025
57d7356
chore: remove mds
nank1ro Dec 11, 2025
88a2f7b
chore: remove unused import
nank1ro Dec 11, 2025
7e5806e
ci: update benchmark worflow
nank1ro Dec 11, 2025
6f5585c
chore: remove debug mode comments
nank1ro Dec 11, 2025
d3f6751
tests: add circular dependency tests
nank1ro Dec 11, 2025
80595ad
fix: typos
nank1ro Dec 11, 2025
51ad98f
Merge branch 'main' into feat/access-providers-in-same-scope
nank1ro Dec 11, 2025
30dba33
ci fixes
nank1ro Dec 15, 2025
aab03ed
fixes
nank1ro Jan 7, 2026
1f9b85f
docs: bump versions
nank1ro Jan 7, 2026
8cf5f27
docs: add node version
nank1ro Jan 7, 2026
bc01ed8
fix: errors for arg provider overrides
nank1ro Jan 7, 2026
fff4f11
fix: test
nank1ro Jan 7, 2026
905545c
docs: update disco_lint readme
nank1ro Jan 7, 2026
d570879
chore: update disco version
nank1ro Jan 7, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/auto_route/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
analyzer:
errors:
always_put_required_named_parameters_first: ignore
specify_nonobvious_property_types: ignore
Comment thread
nank1ro marked this conversation as resolved.
include: package:very_good_analysis/analysis_options.yaml

linter:
Expand Down
5 changes: 4 additions & 1 deletion examples/bloc/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
analyzer:
errors:
specify_nonobvious_property_types: ignore
include: package:very_good_analysis/analysis_options.yaml

linter:
rules:
# since this is just an example, there is no need for ubiquitous documentation.
public_member_api_docs: false
public_member_api_docs: false
1 change: 1 addition & 0 deletions examples/solidart/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ include: package:very_good_analysis/analysis_options.yaml
analyzer:
errors:
always_put_required_named_parameters_first: ignore
specify_nonobvious_property_types: ignore
plugins:
- custom_lint

Expand Down
5 changes: 5 additions & 0 deletions packages/disco/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.0.0

- **FEAT**: Allow providers declared in the same `ProviderScope` to depend on each other, by leveraging the order of declaration. This simplifies the development experience and prevents circular dependencies by design.
Comment thread
nank1ro marked this conversation as resolved.
Outdated
- **FEAT**: Add `debugName` parameter to providers for easier debugging, allowing better identification of providers in error messages and logs.

## 1.0.3+1

- **CHORE**: Improve documentation.
Expand Down
1 change: 1 addition & 0 deletions packages/disco/lib/src/disco_internal.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ part 'models/providers/instantiable_provider.dart';
part 'models/providers/provider_argument.dart';
part 'models/providers/provider.dart';
part 'utils/disco_config.dart';
part 'utils/extensions.dart';
part 'widgets/provider_scope.dart';
part 'widgets/provider_scope_override.dart';
part 'widgets/provider_scope_portal.dart';
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@ part of '../../disco_internal.dart';
/// [_argProvider].
@immutable
class ArgProviderOverride<T extends Object, A> extends Override {
ArgProviderOverride._(
this._argProvider,
T value,
) : _value = value,
ArgProviderOverride._(this._argProvider, T value, {this.debugName})
: _value = value,
super._();

/// The reference of the argument provider to override.
Expand All @@ -24,4 +22,7 @@ class ArgProviderOverride<T extends Object, A> extends Override {
(_) => _value,
lazy: false,
);

/// {@macro Provider.debugName}
final String? debugName;
}
9 changes: 8 additions & 1 deletion packages/disco/lib/src/models/providers/provider.dart
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class Provider<T extends Object> extends InstantiableProvider {

/// {@macro Provider.lazy}
bool? lazy,
this.debugName,
}) : _createValue = create,
_disposeValue = dispose,
_lazy = lazy ?? DiscoConfig.lazy,
Expand All @@ -46,8 +47,9 @@ class Provider<T extends Object> extends InstantiableProvider {
CreateArgProviderValueFn<T, A> create, {
DisposeProviderValueFn<T>? dispose,
bool lazy = true,
String? debugName,
}) =>
ArgProvider._(create, dispose: dispose, lazy: lazy);
ArgProvider._(create, dispose: dispose, lazy: lazy, debugName: debugName);

/// {@template Provider.lazy}
/// Makes the creation of the provided value lazy. defaults to true.
Expand Down Expand Up @@ -118,4 +120,9 @@ class Provider<T extends Object> extends InstantiableProvider {

/// Returns the type of the value.
Type get _valueType => T;

/// {@template Provider.debugName}
/// An optional debug name for this provider.
/// {@endtemplate}
final String? debugName;
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class ArgProvider<T extends Object, A> {
CreateArgProviderValueFn<T, A> create, {
DisposeProviderValueFn<T>? dispose,
bool? lazy,
this.debugName,
}) : _createValue = create,
_disposeValue = dispose,
_lazy = lazy ?? DiscoConfig.lazy;
Expand All @@ -37,7 +38,7 @@ class ArgProvider<T extends Object, A> {
/// {@macro Provider.overrideWithValue}
@visibleForTesting
ArgProviderOverride<T, A> overrideWithValue(T value) =>
ArgProviderOverride._(this, value);
ArgProviderOverride._(this, value, debugName: debugName);

// ---
// DI methods
Expand All @@ -47,7 +48,7 @@ class ArgProvider<T extends Object, A> {
T of(BuildContext context) {
final provider = maybeOf(context);
if (provider == null) {
throw ArgProviderWithoutScopeError(this);
throw ProviderWithoutScopeError(this);
}
return provider;
}
Expand Down Expand Up @@ -81,6 +82,9 @@ class ArgProvider<T extends Object, A> {
dispose: _disposeValue,
lazy: _lazy,
);

/// {@macro Provider.debugName}
final String? debugName;
}

/// {@template InstantiableArgProvider}
Expand Down
19 changes: 19 additions & 0 deletions packages/disco/lib/src/utils/extensions.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
part of '../disco_internal.dart';

extension _DebugNameProvider<T extends Object> on Provider<T> {
// Returns a debug name for the provider.
String? get _debugName {
var s = 'Provider<$_valueType>';
if (debugName != null) s += '(name: $debugName)';
return s;
}
}

extension _DebugNameArgProvider<T extends Object, A> on ArgProvider<T, A> {
// Returns a debug name for the provider with arguments.
String? get _debugName {
var s = 'ArgProvider<$_valueType, $_argumentType>';
if (debugName != null) s += '(name: $debugName)';
return s;
}
}
Loading