Scope visibility flags to compression - #1030
Conversation
|
LGTM, only a changelog entry is missing |
|
@valoq thanks for checking it out, I just added the changelog entry 😄 |
|
@valoq in 0.8 I abandoned the CHANGELOG in favor of having an exhaustive list generated by GitHub when making the releases. The problem was that the CHANGELOG was always missing entries, and other projects auto-generate the CHANGELOG with scripts based on PRs. For example, Zed auto-generates from a nicely formatted PR description, if it's malformed the CI complains with an error. I know giving up the CHANGELOG gave me a sunken cost fallacy feel, and I should've consulted you before doing that :/, sorry. But now that it's done I think we need to revert the CHANGELOG change before merging this. |
Bumps the github-actions group with 1 update: [softprops/action-gh-release](https://github.com/softprops/action-gh-release). Updates `softprops/action-gh-release` from 3 to 3.0.1 - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@v3...v3.0.1) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-version: 3.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
17df120 to
cc58ef0
Compare
|
@marcospb19 all good don't worry about it! happens 😄 I deleted the commit |
3 participants
Summary
--hiddenand--gitignoreto thecompresssubcommanddecompress,list, and the top-level commandTesting
cargo testcargo test --no-default-featurescargo clippy --all-targets --all-features -- -D warningsCloses #327