Skip to content

refactor(api): retire GET/PUT /api/pages/:id/content (Issue #889 Phase 4) #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
otomatty merged 1 commit into from
May 17, 2026
Merged

refactor(api): retire GET/PUT /api/pages/:id/content (Issue #889 Phase 4) #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions server/api/src/__tests__/routes/notes/crud.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,14 +688,15 @@ describe("GET /api/notes/:noteId", () => {
});

it("should change ETag when a page is edited even if notes.updated_at is unchanged", async () => {
// Codex P1 (#856 review): ページ単体編集 (`PUT /api/pages/:id/content` 等)
// で `notes.updated_at` が動かなくても、ETag は変わるべき。pages signal
// (MAX(updated_at), COUNT) を ETag のハッシュ入力に混ぜることで保証する。
// Codex P1 (#856 review): ページ単体編集 (Hocuspocus 経由の本文保存・
// `PUT /api/pages/:id` 等) で `notes.updated_at` が動かなくても、ETag は
// 変わるべき。pages signal (MAX(updated_at), COUNT) を ETag のハッシュ
// 入力に混ぜることで保証する。
//
// Codex P1 (#856 review): editing a page via routes that do not bump
// `notes.updated_at` (e.g. `PUT /api/pages/:id/content`) must still
// shift the ETag. Verified by sending the same note row twice with
// different `MAX(pages.updated_at)` values.
// `notes.updated_at` (Hocuspocus-driven content saves, title renames via
// `PUT /api/pages/:id`) must still shift the ETag. Verified by sending
// the same note row twice with different `MAX(pages.updated_at)` values.
const mockNote = createMockNote();
const { app } = createTestApp([
[mockNote],
Expand Down
Loading
Loading