-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): bump 5 dependencies (date-fns, eslint-plugin-react-hooks, react-resizable-panels, recharts, wrangler) and fix breaking changes #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
3188903
549594d
89a5f65
a195582
d823ccc
4ba6ab3
1c6caa7
721f509
103c1a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -112,7 +112,7 @@ | |
| "clsx": "^2.1.1", | ||
| "cmdk": "^1.1.1", | ||
| "d3": "^7.9.0", | ||
| "date-fns": "^3.6.0", | ||
| "date-fns": "^4.1.0", | ||
| "embla-carousel-react": "^8.5.2", | ||
| "framer-motion": "^12.6.2", | ||
| "hono": "^4.0.0", | ||
|
|
@@ -129,8 +129,8 @@ | |
| "react-error-boundary": "^6.0.0", | ||
| "react-hook-form": "^7.54.2", | ||
| "react-i18next": "^16.5.0", | ||
| "react-resizable-panels": "^2.1.7", | ||
| "recharts": "^2.15.1", | ||
| "react-resizable-panels": "^4.0.15", | ||
| "recharts": "^3.6.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
With this Recharts 3 upgrade, the stats charts that define Useful? React with 👍 / 👎. |
||
| "sonner": "^2.0.1", | ||
| "tailwind-merge": "^3.0.2", | ||
| "three": "^0.175.0", | ||
|
|
@@ -157,7 +157,7 @@ | |
| "bun-types": "latest", | ||
| "eslint": "^9.28.0", | ||
| "eslint-config-prettier": "^9.1.0", | ||
| "eslint-plugin-react-hooks": "^5.2.0", | ||
| "eslint-plugin-react-hooks": "^7.0.1", | ||
| "eslint-plugin-react-refresh": "^0.4.19", | ||
| "globals": "^16.0.0", | ||
| "husky": "^9.0.11", | ||
|
|
@@ -170,7 +170,7 @@ | |
| "typescript-eslint": "^8.38.0", | ||
| "vite": "^7.2.6", | ||
| "vitest": "^2.0.5", | ||
| "wrangler": "^3.0.0" | ||
| "wrangler": "^4.54.0" | ||
| }, | ||
| "workspaces": { | ||
| "packages": [ | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -7,9 +7,9 @@ import { cn } from '@/lib/utils' | |||||
| function ResizablePanelGroup({ | ||||||
| className, | ||||||
| ...props | ||||||
| }: ComponentProps<typeof ResizablePrimitive.PanelGroup>) { | ||||||
| }: ComponentProps<typeof ResizablePrimitive.Group>) { | ||||||
| return ( | ||||||
| <ResizablePrimitive.PanelGroup | ||||||
| <ResizablePrimitive.Group | ||||||
| data-slot="resizable-panel-group" | ||||||
| className={cn('flex h-full w-full data-[panel-group-direction=vertical]:flex-col', className)} | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The upgrade to
Suggested change
|
||||||
| {...props} | ||||||
|
|
@@ -25,11 +25,11 @@ function ResizableHandle({ | |||||
| withHandle, | ||||||
| className, | ||||||
| ...props | ||||||
| }: ComponentProps<typeof ResizablePrimitive.PanelResizeHandle> & { | ||||||
| }: ComponentProps<typeof ResizablePrimitive.Separator> & { | ||||||
| withHandle?: boolean | ||||||
| }) { | ||||||
| return ( | ||||||
| <ResizablePrimitive.PanelResizeHandle | ||||||
| <ResizablePrimitive.Separator | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When this wrapper is used with a vertical group, the v4 Useful? React with 👍 / 👎. |
||||||
| data-slot="resizable-handle" | ||||||
| className={cn( | ||||||
| 'bg-border focus-visible:ring-ring relative flex w-px items-center justify-center after:absolute after:inset-y-0 after:left-1/2 after:w-1 after:-translate-x-1/2 focus-visible:ring-1 focus-visible:ring-offset-1 focus-visible:outline-hidden data-[panel-group-direction=vertical]:h-px data-[panel-group-direction=vertical]:w-full data-[panel-group-direction=vertical]:after:left-0 data-[panel-group-direction=vertical]:after:h-1 data-[panel-group-direction=vertical]:after:w-full data-[panel-group-direction=vertical]:after:-translate-y-1/2 data-[panel-group-direction=vertical]:after:translate-x-0 [&[data-panel-group-direction=vertical]>div]:rotate-90', | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the
Suggested change
|
||||||
|
|
@@ -42,7 +42,7 @@ function ResizableHandle({ | |||||
| <GripVerticalIcon className="size-2.5" /> | ||||||
| </div> | ||||||
| )} | ||||||
| </ResizablePrimitive.PanelResizeHandle> | ||||||
| </ResizablePrimitive.Separator> | ||||||
| ) | ||||||
| } | ||||||
|
|
||||||
|
|
||||||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request title and description are misleading. While they only mention bumping
date-fns, this PR also includes major version upgrades for several other critical dependencies:recharts(v2 to v3),react-resizable-panels(v2 to v4),eslint-plugin-react-hooks(v5 to v7), andwrangler(v3 to v4).Mixing multiple major upgrades in a single PR makes it difficult to track breaking changes and increases the risk of regressions. It is recommended to update the PR title and description to reflect all major changes, or ideally, split these into separate pull requests to ensure each upgrade is properly validated.