Skip to content

remove seek from NetworkMessage #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xyron98 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove seek from NetworkMessage #4891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion data/cpplinter.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ Tile = {}
---@field addItem fun(self: NetworkMessage, item: Item)
---@field addItemId fun(self: NetworkMessage, itemId: number)
---@field reset fun(self: NetworkMessage)
---@field seek fun(self: NetworkMessage, position: number)
---@field tell fun(self: NetworkMessage): number
---@field len fun(self: NetworkMessage): number
---@field skipBytes fun(self: NetworkMessage, count: number)
Expand Down
13 changes: 0 additions & 13 deletions src/luascript.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2501,7 +2501,6 @@ void LuaScriptInterface::registerFunctions()
registerMethod(L, "NetworkMessage", "addItemId", LuaScriptInterface::luaNetworkMessageAddItemId);

registerMethod(L, "NetworkMessage", "reset", LuaScriptInterface::luaNetworkMessageReset);
registerMethod(L, "NetworkMessage", "seek", LuaScriptInterface::luaNetworkMessageSeek);
registerMethod(L, "NetworkMessage", "tell", LuaScriptInterface::luaNetworkMessageTell);
registerMethod(L, "NetworkMessage", "len", LuaScriptInterface::luaNetworkMessageLength);
registerMethod(L, "NetworkMessage", "skipBytes", LuaScriptInterface::luaNetworkMessageSkipBytes);
Expand Down Expand Up @@ -6219,18 +6218,6 @@ int LuaScriptInterface::luaNetworkMessageReset(lua_State* L)
return 1;
}

int LuaScriptInterface::luaNetworkMessageSeek(lua_State* L)
{
// networkMessage:seek(position)
NetworkMessage* message = tfs::lua::getUserdata<NetworkMessage>(L, 1);
if (message && isNumber(L, 2)) {
tfs::lua::pushBoolean(L, message->setBufferPosition(tfs::lua::getNumber<uint16_t>(L, 2)));
} else {
lua_pushnil(L);
}
return 1;
}

int LuaScriptInterface::luaNetworkMessageTell(lua_State* L)
{
// networkMessage:tell()
Expand Down
1 change: 0 additions & 1 deletion src/luascript.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,6 @@ class LuaScriptInterface
static int luaNetworkMessageAddItemId(lua_State* L);

static int luaNetworkMessageReset(lua_State* L);
static int luaNetworkMessageSeek(lua_State* L);
static int luaNetworkMessageTell(lua_State* L);
static int luaNetworkMessageLength(lua_State* L);
static int luaNetworkMessageSkipBytes(lua_State* L);
Expand Down