Skip to content

Fix memory leaks on reloads - #4773

Open
MillhioreBT wants to merge 2 commits into
otland:masterfrom
Unreal-TFS:fix_memory_leak_reloads
Open

Fix memory leaks on reloads#4773
MillhioreBT wants to merge 2 commits into
otland:masterfrom
Unreal-TFS:fix_memory_leak_reloads

Conversation

@MillhioreBT

Copy link
Copy Markdown
Contributor

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

These changes will cause that when you do /reload the scripts will be cleaned from the reference table, this way there will be no memory leak.

The only case that is not covered is /reload items, for some reason this method produces an increase in memory on each reload: bool Items::loadFromXml()

Issues addressed: Nothing!

@nekiro

nekiro commented Dec 22, 2024

Copy link
Copy Markdown
Member

Looks pretty good, I'll check this in-game soon

@nekiro nekiro mentioned this pull request Dec 24, 2024
3 tasks
@NRH-AA

NRH-AA commented Dec 18, 2025

Copy link
Copy Markdown

Finally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants