Fix memory leaks on reloads - #4773
Open
MillhioreBT wants to merge 2 commits into
Open
Conversation
MillhioreBT
requested review from
a user,
DSpeichert,
EvilHero90,
nekiro and
ranisalt
August 14, 2024 22:43
Member
|
Looks pretty good, I'll check this in-game soon |
|
Finally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
These changes will cause that when you do
/reloadthe scripts will be cleaned from the reference table, this way there will be no memory leak.The only case that is not covered is
/reload items, for some reason this method produces an increase in memory on each reload:bool Items::loadFromXml()Issues addressed: Nothing!