📖 docs: update docker image naming to include v5 suffix#4973
📖 docs: update docker image naming to include v5 suffix#4973LoveChauhan-18 wants to merge 3 commits intoossf:mainfrom
Conversation
LoveChauhan-18
requested review from
jeffmendoza and
justaugustus
and removed request for
a team
dosubot
Bot
added
size:S
Signed-off-by: Love Kumar Chauhan <lovechauhan6564@gmail.com>
LoveChauhan-18
force-pushed
the
fix/docker-image-naming-v5
branch
from
a9d5d5c to
82601d1
Compare
|
Hi, just checking in — please let me know if any further changes are needed from my side. Happy to update! |
justaugustus
left a comment
justaugustus
left a comment
There was a problem hiding this comment.
Thanks for filing this, @LoveChauhan-18.
The PR title verifier tests are currently failing. It seems you've copied in the commit from my PR (#4972), without attribution.
Please hang on while maintainers review and merge the existing fix and then you can rebase your PR on top of it.
The kubebuilder-release-tools Docker image (gcr.io/kubebuilder/pr-verifier) became unavailable on March 18, 2025, causing all PR verifier checks to fail. This commit replaces the Docker action with a shell script that: - Performs the same PR title verification for emoji prefixes - Checks out base branch to run the verification script - Validates title length (500 char max) - Uses printf for safer output handling - Maintains compatibility with both emoji and :emoji: formats Supported emoji prefixes: - ⚠ Breaking change - ✨ Non-breaking feature - 🐛 Patch fix - �� Documentation - 🚀 Release - 🌱 Infra/Tests/Other Co-authored-by: Stephen Augustus <foo@auggie.dev> Signed-off-by: Love Kumar Chauhan <lovechauhan6564@gmail.com>
LoveChauhan-18
force-pushed
the
fix/docker-image-naming-v5
branch
from
82601d1 to
069d33d
Compare
Signed-off-by: Love Kumar Chauhan <lovechauhan6564@gmail.com>
dosubot
Bot
added
size:L
|
Hey @justaugustus, sorry about that — fixed it up! Added the Let me know if there's anything else! |
There was a problem hiding this comment.
Is there a reason you want the V5 suffix back? It was removed intentionally in #4885
edit:
However, this package name is incorrect for the current versioning scheme, and attempting to pull it results in a "denied" error from the registry because the package does not exist.
Whoops, we just need to cut a release. I can commit to releasing on Thursday
|
This pull request has been marked stale because it has been open for 10 days with no activity |
|
The docker image should be published under the specified URI now, I think we can close this. |
3 participants
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
This is a documentation and build configuration update.
What is the current behavior?
The README.md, Makefile, and publishimage.yml refer to the docker image as
ghcr.io/ossf/scorecard:latest. However, this package name is incorrect for the current versioning scheme, and attempting to pull it results in a "denied" error from the registry because the package does not exist.What is the new behavior (if this is a feature change)?**
All references have been updated to include the correct
/v5suffix (e.g.,ghcr.io/ossf/scorecard/v5:latest). This ensures that users following the documentation can successfully pull and run the Scorecard docker image.(Not applicable as these are documentation and CI configuration changes)
Which issue(s) this PR fixes
Fixes #4951
Special notes for your reviewer
NONE
Does this PR introduce a user-facing change?
Yes, it corrects the docker pull commands in the README.