Skip to content

Feature/GitHubAuth Updated#197

Open
kiaramathews wants to merge 6 commits intomainfrom
Feature/GithubAuthen
Open

Feature/GitHubAuth Updated#197
kiaramathews wants to merge 6 commits intomainfrom
Feature/GithubAuthen

Conversation

@kiaramathews
Copy link
Copy Markdown
Collaborator

@kiaramathews kiaramathews commented Apr 12, 2026

Description

In this PR, I have successfully implemented GitHub Authentication so users can successfully link their GitHub to the website. This will help us develop future features, for example, doing tasks and edits with a specific role. I have also included the updated documentation with the steps on how to reproduce the implementation. UPDATE: fixed errors and added redirection back to homescreen after login is successful.

Fixes # 172 and 166

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested on my main browser and was able to successfully link my GitHub account
  • Tested on an incognito tab signed out of my GitHub account

Test Configuration: npm run dev

Language Version: jsx
Webpage (if applicable):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshot of Output

Please provide a screenshot of your output below (during all tests if applicable)

@hcaballero2 hcaballero2 mentioned this pull request Apr 12, 2026
14 tasks
@hcaballero2
Copy link
Copy Markdown
Collaborator

hi @kiaramathews thank you for working these comments in! when trying to run: npm run dev I ran into an error that required me to install firebase (npm install firebase) can you make sure it is properly installed so we wont have that issue once it is merged? also when logging in all you receive is the pop up that the login was sucessful, you still remain on the login page and it prompts you to sign in again. there should be some indication that the user is logged in and it should redirect them back to the home page upon sucessful log in. could you also show the data that is stored in the Firebase upon login? (Just a screenshot here is fine!) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants