-
Notifications
You must be signed in to change notification settings - Fork 14
Lable toggle #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Lable toggle #337
Changes from 8 commits
bbb5524
2b22cc0
50b9a87
65d4152
9a8a112
713b2c6
4cdbaf8
ebe1235
bd7d363
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,4 +21,7 @@ Thumbs.db | |
|
|
||
| # Cache files | ||
| __pycache__/ | ||
| *.pyc | ||
| *.pyc | ||
|
|
||
| # XML files | ||
| *.xml | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this committed? This doesn't seem relevant. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -137,7 +137,9 @@ <h2>Visual Reference</h2> | |
| </div> | ||
| <div class="images-content"> | ||
| <div id="bone-image-container" role="region" aria-live="polite"></div> | ||
|
|
||
| <div class="image-controls"> | ||
| <button id="toggle-labels-button" type="button" class="btn-secondary">Toggle Labels</button> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The text in here being "Toggle Labels" has the effect that the button says "Toggle Labels" until you click on it, after which it says either "show" or "hide." The inconsistency feels a bit clunky to me I was thinking maybe the default here should just be "hide" instead of "toggle"...but after reading Jennifer's comment I think it might be simplest just to have it always say "toggle" and never "hide" or "show," just so it never ends up saying the wrong thing |
||
| </div> | ||
| </div> | ||
| </section> | ||
| </div> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1800,6 +1800,10 @@ button:disabled { | |
| height: 100%; | ||
| } | ||
|
|
||
| #bone-image-container.labels-hidden .annotation-labels { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be good to also hide the pointer lines that are being overlaid on the images. It looks like they have the class name "annotation-svg", so see if hiding those works.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm actually going back on this...after looking at it I think we'd want to keep the lines, so they can see what parts of the bone is a distinctly named part. I think it would better facilitate the point of toggling the labels which is quickly quizzing oneself. |
||
| visibility: hidden !important; | ||
| } | ||
|
|
||
| /* In templates/style.css */ | ||
|
|
||
| /* Lines: Use a dark color and a thin stroke */ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this committed? This doesn't seem relevant.