Skip to content

Update GAP.jl to 0.16, i.e. GAP to 4.15.1 - #5374

Merged
lgoettgens merged 6 commits into
masterfrom
lg/GAP-0.16
Oct 24, 2025
Merged

Update GAP.jl to 0.16, i.e. GAP to 4.15.1#5374
lgoettgens merged 6 commits into
masterfrom
lg/GAP-0.16

Conversation

@lgoettgens

@lgoettgens lgoettgens commented Sep 25, 2025

Copy link
Copy Markdown
Member

Resolves #5388, resolves #5387, closes #5283.

@lgoettgens lgoettgens added package: GAP WIP NOT ready for merging release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Sep 25, 2025
@fingolfin fingolfin changed the title Update GAP.jl to 0.16, i.e. GAP to 4.15.0 Update GAP.jl to 0.16, i.e. GAP to 4.15.1 Oct 22, 2025
@lgoettgens

Copy link
Copy Markdown
Member Author

The one remaining failures that running the testsuite on tutulla against GAP.jl master and https://github.com/lgoettgens/Hecke.jl#lg/GAP-0.16 reports is due to

returning a different character and thus some changes in the following lines of output. What do we do here? Also use the sort from #5486? (ping @fingolfin @ThomasBreuer)

@lgoettgens lgoettgens removed the WIP NOT ready for merging label Oct 23, 2025
@lgoettgens lgoettgens closed this Oct 23, 2025
@lgoettgens lgoettgens reopened this Oct 23, 2025
@lgoettgens
lgoettgens marked this pull request as ready for review October 23, 2025 19:25
@lgoettgens

Copy link
Copy Markdown
Member Author

This now waits for thofma/Hecke.jl#2054

@lgoettgens

Copy link
Copy Markdown
Member Author

The one remaining failures that running the testsuite on tutulla against GAP.jl master and https://github.com/lgoettgens/Hecke.jl#lg/GAP-0.16 reports is due to

returning a different character and thus some changes in the following lines of output. What do we do here? Also use the sort from #5486? (ping @fingolfin @ThomasBreuer)

We still need to resolve this issue

@ThomasBreuer

Copy link
Copy Markdown
Member

We still need to resolve this issue

One possibility is what I had sketched yesterday in Slack:

tbl = character_table(G);
F, _ = abelian_closure(QQ);
p = x -> order(kernel(x)[1]) == 8 && x(G(g2)) == F(z_3);
chi = iterate(x for x in tbl if p(x))[1];

This way, we describe the character we are interested in, the condition is encoded via p.
The code is ugly, but since we want a character with irrational values, we have to use information about the group.
Shall I make a pull request for that, or do you have a better idea?

@lgoettgens

Copy link
Copy Markdown
Member Author

I have an idea how to slightly simplify your code a bit. I'll update this PR in a bit

@lgoettgens
lgoettgens enabled auto-merge (squash) October 24, 2025 12:11
@lgoettgens
lgoettgens merged commit 7fc5866 into master Oct 24, 2025
35 checks passed
@lgoettgens
lgoettgens deleted the lg/GAP-0.16 branch October 24, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: GAP release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Isomorphism from fp group to pc group fails Induction of pc group character does not work

3 participants