Prepare juliainterface for GAP 4.15 - #1248
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1248 +/- ##
==========================================
+ Coverage 76.91% 76.93% +0.02%
==========================================
Files 60 60
Lines 4778 4809 +31
==========================================
+ Hits 3675 3700 +25
- Misses 1103 1109 +6
🚀 New features to boost your workflow:
|
|
Huh, CI breaks -- a race condition? Maybe we need to protect the compilation of JuliaInterface against races with some kind of locking? |
So, yeah, it tries to compile (However that would still end up re-compiling |
|
Looks like an issue, but nothing new and not relevant to fix ASAP IMO |
Alternative to most parts of #1239 (as discussed today with @fingolfin).
We should merge this PR asap, as the juliainterface code is now compatible with both gap 4.14 and 4.15. Therefore, the circular dependency mentioned in #1244 (comment) (point 6) should no longer be there.
I would suggest that we merge this, and then I will try to do all the rebuilds with this against the gap beta3 (which hopefully contains gap-system/gap#6124)