Always use seed argument directly#2516
Merged
Merged
Conversation
Wire new CLI flags --bootc-remote and --image-size through manifest so that test configs can be built via image-builder build/manifest. Related: HMS-10855
This commit swaps usage of build in tests to using image-builder directly. After swapping from build to image-builder in tests, it is possible to use options instead of solely just a config file. This commit extracts options from the json config: --ostree-ref, --ostree-url, --ostree-parent, --bootc-installer-payload-ref, --bootc-remote, --image-size, and --extra-repo. It also extracts the blueprint part of the config into a standalone file, so that it can be used for building with image-builder. The commit also changes find_image_file function which now looks for different filename, since image-builder creates a different file than ./bin/build. Related: HMS-10855
The test keep failing due to missing fuse. Disabling the test since this is experimental.
For uploaders for both AWS and Azure, we check for missing arguments, and fail early when uploading, and skip upload during build when the flag is not provided. For openstack, we do not do that. As a result, upload to openstack fails. This commit adds a check for --openstack-image before creating an openstack uploader and fails with ErrUploadConfigNotProvided if not provided.
Rename the 'manifest' variable to 'mf' and the serialised manifest variable from 'mf' to 'mfs'. We need to use the 'manifest' package.
Builds in CI now use image-builder, which by default generates manifests with the librepo instead of the curl source. We need to generate manifests in a compatible way, otherwise we will keep rebuilding every image in every CI run.
Always use the rngseed directly. There's no need to derive it from the distro and architecture name anymore.
achilleas-k
force-pushed
the
something-with-the-seed
branch
2 times, most recently
from
53f2da5 to
b23bac4
Compare
Member
|
This is rebased on top of #2462 is that correct? |
achilleas-k
force-pushed
the
something-with-the-seed
branch
from
b23bac4 to
d2ca267
Compare
supakeen
previously approved these changes
Jul 13, 2026
Member
Author
croissanne
previously approved these changes
Jul 13, 2026
Member
Author
|
https://gitlab.com/redhat/services/products/image-builder/ci/images/-/jobs/15319989224 🎉 |
Member
Author
|
Found an issue with RHEL. Fixed it. |
RHEL manifests set the RHSM fact. If the gen-manifests fact does not match the one from 'image-builder build', the CI cache wont work properly for RHEL images.
achilleas-k
force-pushed
the
something-with-the-seed
branch
from
c57edbf to
800d092
Compare
croissanne
approved these changes
Jul 13, 2026
supakeen
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 155ae59 we added
SeedArgFor()which derives the RNG seed from the seed option combined with the distribution and architecture names. This isn't necessary any more and only complicates things.Always use the rngseed directly.