cmd/image-builder: mock simple integration tests (HMS-10857)#2473
Merged
Conversation
achilleas-k
previously approved these changes
Jun 29, 2026
achilleas-k
left a comment
achilleas-k
left a comment
Member
There was a problem hiding this comment.
Very nice.
I'm sure we can get more improvements to the loading times once we're done with the merge and can focus on the loader.
Member
Author
|
It seems that with some (new?) tests we now have downstream failures in RPM builds or is this caused by this PR. I'll take a look in the morning. |
supakeen
force-pushed
the
mock-unit-tests
branch
5 times, most recently
from
July 4, 2026 07:13
c6bf538 to
cc3c92e
Compare
Member
Author
|
Rebased to resolve conflicts. |
achilleas-k
previously approved these changes
Jul 6, 2026
Member
Author
|
Something broke during the rebase; let's only ack when it actually goes green this time 😞 |
achilleas-k
previously approved these changes
Jul 6, 2026
avitova
previously approved these changes
Jul 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 9, 2026
supakeen
force-pushed
the
mock-unit-tests
branch
from
July 10, 2026 05:57
07fb62f to
5ca4251
Compare
Member
Author
|
Had to rebase for conflicts. |
supakeen
force-pushed
the
mock-unit-tests
branch
from
July 11, 2026 04:59
5ca4251 to
fc903fe
Compare
achilleas-k
previously approved these changes
Jul 13, 2026
brlane-rht
previously requested changes
Jul 13, 2026
brlane-rht
left a comment
brlane-rht
left a comment
Contributor
There was a problem hiding this comment.
Looks good other than using new.
Mock the integration tests that are easy and straightforward to mock. This reduces the test time significantly as we're not performing real dependency solving anymore in most of the tests. The resolvers are duplicated here but could later be shared. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
supakeen
force-pushed
the
mock-unit-tests
branch
from
July 14, 2026 08:52
fc903fe to
98e4bb2
Compare
avitova
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mock the integration tests that are easy and straightforward to mock. This reduces the test time significantly as we're not performing real dependency solving anymore in most of the tests.
Note this doesn't really make things faster that much. The test suite still takes long as almost every test calls
main.Run()which loads distribution definitions which takes 2-3 seconds for every test.We also can't make the tests parallel without rewriting the entire mocking strategy since we're mocking globals 🙁