Repository navigation
NO-ISSUE: use ghcr.io registry image to avoid Docker Hub rate limits - #1566
redhat-chai-bot wants to merge 1 commit into
Conversation
|
@redhat-chai-bot: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
ℹ️ E2E CaaS Full Install -- Skipped This suite never reached the point of actually running -- see the run for why (e.g. the e2e-readiness gate wasn't met, or this suite wasn't needed for what changed). ℹ️ E2E BMaaS Full Install -- Skipped This suite never reached the point of actually running -- see the run for why (e.g. the e2e-readiness gate wasn't met, or this suite wasn't needed for what changed). ℹ️ E2E VMaaS Full Install -- Skipped This suite never reached the point of actually running -- see the run for why (e.g. the e2e-readiness gate wasn't met, or this suite wasn't needed for what changed). |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.
WalkthroughThe integration test setup now starts the local TLS OCI registry from ChangesIntegration registry setup
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The integration setup uses the GHCR registry image and retains its existing TLS and chart-push flow. No merge-blocking failure is established. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the main change: replacing the Docker Hub registry image with a GHCR image to avoid Docker Hub rate limits. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| No-Hardcoded-Secrets | |
The pull request changes only the container image reference in osac-aap/tests/integration/setup_test_env.sh, from registry:2 to ghcr.io/distribution/distribution:3. The changed value contains no… |
| No-Weak-Crypto | |
The pull request changes only the container image reference to ghcr.io/distribution/distribution:3. The added line contains no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comp… |
| No-Injection-Vectors | |
The pull request changes only a static container image reference in osac-aap/tests/integration/setup_test_env.sh: registry:2 becomes ghcr.io/distribution/distribution:3. The change adds no SQL, … |
| Container-Privileges | |
The pull request changes only the registry image in a shell-based container launch. The diff adds no --privileged, host PID/network/IPC settings, SYS_ADMIN capability, allowPrivilegeEscalation, … |
| No-Sensitive-Data-In-Logs | |
PASS. The pull request changes only the container image argument from registry:2 to ghcr.io/distribution/distribution:3 in the integration setup script. It adds no logging, credentials, tokens, pa… |
| Ai-Attribution | |
AI use is explicitly identified in the PR description and commit message. The commit includes an Assisted-by: Claude Code (claude.ai) trailer and does not include a Co-Authored-By trailer. |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
- Create a new PR
Comment @coderabbitai help to get the list of available commands.
The CI integration test uses a local OCI registry container. Pulling the `registry:2` image from Docker Hub is subject to unauthenticated pull rate limits, which cause intermittent CI failures. Switch to the equivalent CNCF Distribution image hosted on GitHub Container Registry (`ghcr.io/distribution/distribution:2`), which has no such limits. Assisted-by: Claude Code (claude.ai) Signed-off-by: Chai Bot <chai-bot@redhat.com>
928f32d to
ba3d117
Compare
🧭 Jobs Selection (informational only)E2E Suites
No AI validation needed -- nothing in this PR was recognized as relevant to any E2E suite. Unit Tests
Integration Tests
Helm Lint
Checks & Builds
Every table above is informational only -- nothing here gates whether a job actually runs. The E2E Suites table can use AI judgment for ambiguous files; every other table is deterministic-only (no AI). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz, redhat-chai-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
E2E on
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
E2E on CodeRabbit approvalAll merge-required e2e gates already success on HEAD — skipping replay. Accepted: |
This branch has not been deployed
3 participants
Summary
Swap the Docker Hub
registry:2image reference in the osac-aap integration test setup toghcr.io/distribution/distribution:2— the same upstream CNCF Distribution image, hosted on GitHub Container Registry.Problem
CI runners share IP addresses and hit Docker Hub's unauthenticated pull rate limit (100 pulls per 6 hours per IP), causing integration test failures:
Fix
Replace the unqualified
registry:2(which resolves todocker.io/library/registry:2) with the equivalentghcr.io/distribution/distribution:2. This avoids Docker Hub rate limits entirely without requiring any secrets or workflow changes.This is consistent with the existing mirror pattern in the repo (see
.github/workflows/mirror-envoy.yaml).AI-generated. Review for accuracy.
@ygalblum requested from Slack