[AI] OSAC-2927: CaaS: ClusterOrderPhaseDeleting not synced to fulfillment-service

[osac-jira-ai-issue-solver]

Resolves OSAC-2927

Summary

• Sync ClusterOrderPhaseDeleting to CLUSTER_STATE_DELETING in the clusterorder-feedback controller — previously this mapping was commented out with a TODO, causing clusters under deletion to appear as READY/PROGRESSING in the fulfillment-service Watch stream
• Add feedback finalizer management (osac.openshift.io/clusterorder-feedback) matching the pattern used by all other feedback controllers, ensuring the DELETING state is persisted before the CR is garbage-collected
• Handle NotFound gracefully during deletion and call Signal RPC when the feedback finalizer is the last one remaining

Test plan

• 12 new unit tests covering all phase mappings, finalizer lifecycle, Signal RPC, NotFound handling, and edge cases
• Full unit test suite passes (624 controller specs)
• make lint passes (0 issues)
• go build ./... succeeds
• E2E: verify metering receives CLUSTER_STATE_DELETING on ClusterOrder deletion

[openshift-ci-robot]

@osac-jira-ai-issue-solver[bot]: This pull request references OSAC-2927 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Resolves OSAC-2927

Summary

• Sync ClusterOrderPhaseDeleting to CLUSTER_STATE_DELETING in the clusterorder-feedback controller — previously this mapping was commented out with a TODO, causing clusters under deletion to appear as READY/PROGRESSING in the fulfillment-service Watch stream
• Add feedback finalizer management (osac.openshift.io/clusterorder-feedback) matching the pattern used by all other feedback controllers, ensuring the DELETING state is persisted before the CR is garbage-collected
• Handle NotFound gracefully during deletion and call Signal RPC when the feedback finalizer is the last one remaining

Test plan

• 12 new unit tests covering all phase mappings, finalizer lifecycle, Signal RPC, NotFound handling, and edge cases
• Full unit test suite passes (624 controller specs)
• make lint passes (0 issues)
• go build ./... succeeds
• E2E: verify metering receives CLUSTER_STATE_DELETING on ClusterOrder deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: osac-jira-ai-issue-solver[bot]
Once this PR has been reviewed and has the lgtm label, please assign eranco74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[osac-jira-ai-issue-solver]

AI Session Costs

Session	Cost
New ticket	$4.68
Merge conflict resolution	$1.36
Feedback (1)	$2.42
Feedback (2) (no changes)	$0.76
Feedback (2) retry 1 (no changes)	$0.70
Merge conflict resolution	$0.60
Merge conflict resolution	$0.82
Total	$11.34

[osac-jira-ai-issue-solver]

CI failures addressed in 3236e49.

[osac-jira-ai-issue-solver]

CI failures addressed in no-changes.

[osac-jira-ai-issue-solver]

CI failures addressed in no-changes.

[eranco74]

/ok-to-test

[eranco74]

/retest-required

[github-actions]

Labeled ok-to-test. Re-ran 1 failed run(s).

[github-actions]

No failed workflow runs found for this PR at commit 3236e49.