Repository navigation
Conversation
023a544 to
e65e9a0
Compare
| sub run { | ||
| select_console 'root-console'; | ||
|
|
||
| my $expected = get_test_suite_data()->{kernel_version} |
There was a problem hiding this comment.
you don't need test data, because you can only garantee that the command output will give you the nvidia64kb part, the kernel version will be changing with the builds I guess.
7f87819 to
3383824
Compare
Introduce validation test module to verify kernel version using uname.
| # Summary: Validate the kernel version of the installed system. | ||
|
|
||
| # Summary: Validate the kernel version of the installed system. | ||
| # Compare the output of "uname -r" with the kernel version from test data. |
There was a problem hiding this comment.
with the kernel version s/from test data/'nvidia64kb'/
|
Remove test data files which are not needed any more. |
There was a problem hiding this comment.
I think you'd better create a new schedule file for Nvidia test, it seems your module validate_kernel_version only for Nvidia test.
There was a problem hiding this comment.
Same for other schedule files.
|
|
||
| # Summary: Validate the kernel version of the installed system. | ||
|
|
||
| # Summary: Validate the kernel version of the installed system. |
There was a problem hiding this comment.
line6 and line8 are identical, do we really need that? thanks.
| # Summary: Validate the kernel version of the installed system. | ||
|
|
||
| # Summary: Validate the kernel version of the installed system. | ||
| # Compare the output of "uname -r" with the kernel version from test data. |
There was a problem hiding this comment.
we don't use test data in the code. so we can rephrase it.
There was a problem hiding this comment.
no need for any comment about specific implementation repeating the command.
| @@ -1,4 +1,5 @@ | |||
| --- | |||
| kernel_version: 6.12.0-160100.1-nvidia64kb | |||
There was a problem hiding this comment.
agama_sle_nvidia_immutable.yaml
(From more generic to more specific)
| # Copyright 2026 SUSE LLC | ||
| # SPDX-License-Identifier: FSFAP | ||
|
|
||
| # Summary: Validate the kernel version of the installed system. |
There was a problem hiding this comment.
Validate the installed system has a NVIDIA-specific kernel.
| my $kernel = script_output('uname -r'); | ||
|
|
||
| assert_matches(qr/^.+-nvidia64kb$/, $kernel, | ||
| "Wrong kernel version '. Got '$kernel'"); |
There was a problem hiding this comment.
assert_matches(qr/^.+-nvidia64kb$/, script_output('uname -r'), "The installed system doesn't have a NVIDIA-specific kernel");
| - name: SLES-NVIDIA-%VERSION% | ||
| alias: SUSE_Linux_Enterprise_Server_for_NVIDIA_%VERSION%_%ARCH%:SLES-NVIDIA-%VERSION% | ||
| uri: http://openqa.suse.de/assets/repo/SLES-%VERSION%-%ARCH%-Build%BUILD%/ | ||
| uri: http://openqa.suse.de/assets/repo/SLES-NVIDIA-%VERSION%-%ARCH%-Build%BUILD% |
There was a problem hiding this comment.
you are missing the final / for each uri.
Introduce validation test module to verify kernel version using "uname -r"