feat: add Windows support - #8
Merged
Merged
Conversation
Replace Unix-only `std::os::unix::fs::FileExt` (pread/pwrite) with the cross-platform `positioned-io` crate, which delegates to pread/pwrite on Unix and seek_read/seek_write on Windows. - Swap all read_exact_at/write_all_at/write_at call sites from (buf, offset) to (offset, buf) argument order - Disambiguate flush() calls between std::io::Write and WriteAt traits - Add Windows to CI test matrix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
LGTM, I've just polished a bit the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::os::unix::fs::FileExtwith the cross-platformpositioned-iocrate (v0.3), enabling compilation and correct behavior on Windowsread_exact_at/write_all_at/write_atcall sites from(buf, offset)to(offset, buf)to matchpositioned-ioAPIflush()calls betweenstd::io::Writeandpositioned_io::WriteAttraitswindows-latestto CI test matrix (lint/fmt/clippy kept Ubuntu-only)Test plan
ubuntu-latestwindows-latest🤖 Generated with Claude Code