Skip to content

MAIL_REGEX should be limited #96

Description

@tballison

If you try to detect a string with 50000 'a's, the MAIL_REGEX in URLTextFilter takes a really, really long time.

If you add reasonable limits, the performance is much better.
private static final Pattern MAIL_REGEX = Pattern.compile("[-_.0-9A-Za-z]+@[-0-9A-Za-z]+[-.0-9A-Za-z]+");

to->

    private static final Pattern MAIL_REGEX = Pattern.compile("[-_.0-9A-Za-z]{1,250}@[-_0-9A-Za-z]{1,250}[-_.0-9A-Za-z]{1,250}");

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions