Fix #6430, #6431: Preserve worked example list spacing - #6432
Open
Neer-rn wants to merge 3 commits into
Open
Conversation
Contributor
Coverage ReportResultsNumber of files assessed: 1 Exempted coverageFiles exempted from coverage
|
Collaborator
Author
|
@adhiamboperes Please review and test this when you get time. |
adhiamboperes
left a comment
Contributor
There was a problem hiding this comment.
@Neer-rn, the regex looks good. I just need to test this manually.
Collaborator
Author
|
@adhiamboperes Please test this manually and let me know. If it doesn’t work as expected, I will need to make another revision. |
Contributor
Collaborator
Author
|
@adhiamboperes I have fixed the it. Please review this.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Explanation
Fixes #6430
Fixes #6431
Worked example lists were not parsed correctly when the list tags had extra attributes. Because of this, spaces between list items and paragraphs were missing. Some joined words were also shown as links.
This PR fixes the list parsing and adds tests for these cases.
Essential Checklist
Disclosure of LLM Usage
No