Fix #6258: Deprecate Lollipop by ShankhanilSaha · Pull Request #6399 · oppia/oppia-android

ShankhanilSaha · 2026-08-28T10:21:17Z

Fixes #6258

Explanation

Changes minimum SDK version to 23.
Deprecates lollipop support and minimum version is now marshmellow.

Essential Checklist

The PR title starts with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The explanation section above starts with "Fixes #bugnum: " (If this PR fixes part of an issue, use instead: "Fixes part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

ShankhanilSaha · 2026-08-28T10:21:57Z

@adhiamboperes fixed the merge conflicts and re-opened this. PTAL

oppiabot · 2026-08-28T10:25:02Z

Unassigning @ShankhanilSaha since a re-review was requested. @ShankhanilSaha, please make sure you have addressed all review comments. Thanks!

github-actions · 2026-08-28T14:09:14Z

Coverage Report

Results

Number of files assessed: 3
Overall Coverage: 82.53%
Coverage Analysis: FAIL ❌

Failing coverage

File	Coverage	Lines Hit	Status	Min Required
AndroidLintRunner.kt scripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt	67.32%	239 / 355	❌	70%

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
LintAnalysisReporter.kt scripts/src/java/org/oppia/android/scripts/lint/LintAnalysisReporter.kt	95.05%	422 / 444	✅	70%
LintModelCreator.kt scripts/src/java/org/oppia/android/scripts/lint/LintModelCreator.kt	81.82%	180 / 220	✅	70%

To learn more, visit the Oppia Android Code Coverage wiki page

github-actions · 2026-08-30T13:19:41Z

Coverage Report

Results

Number of files assessed: 12
Overall Coverage: 88.53%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
EdgeToEdgeHelper.kt app/src/main/java/org/oppia/android/app/utility/edgetoedge/EdgeToEdgeHelper.kt	96.85%	246 / 254	✅	70%
LintAnalysisReporter.kt scripts/src/java/org/oppia/android/scripts/lint/LintAnalysisReporter.kt	95.05%	422 / 444	✅	70%
AndroidLintRunner.kt scripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt	78.59%	279 / 355	✅	70%
LintModelCreator.kt scripts/src/java/org/oppia/android/scripts/lint/LintModelCreator.kt	81.82%	180 / 220	✅	70%

Exempted coverage

Files exempted from coverage

File	Exemption Reason
SurveyWelcomeDialogFragmentPresenter.kt app/src/main/java/org/oppia/android/app/survey/SurveyWelcomeDialogFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
SurveyOutroDialogFragment.kt app/src/main/java/org/oppia/android/app/survey/SurveyOutroDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
SurveyWelcomeDialogFragment.kt app/src/main/java/org/oppia/android/app/survey/SurveyWelcomeDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
SurveyOutroDialogFragmentPresenter.kt app/src/main/java/org/oppia/android/app/survey/SurveyOutroDialogFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
HintsAndSolutionDialogFragmentPresenter.kt app/src/main/java/org/oppia/android/app/hintsandsolution/HintsAndSolutionDialogFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
HintsAndSolutionDialogFragment.kt app/src/main/java/org/oppia/android/app/hintsandsolution/HintsAndSolutionDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
ConceptCardFragmentPresenter.kt app/src/main/java/org/oppia/android/app/topic/conceptcard/ConceptCardFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
ConceptCardFragment.kt app/src/main/java/org/oppia/android/app/topic/conceptcard/ConceptCardFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

adhiamboperes

@ShankhanilSaha, PTAL at the failing lint check.

ShankhanilSaha · 2026-08-31T06:17:28Z

@adhiamboperes the tracking issue has been created. #6409

github-actions · 2026-08-31T06:43:49Z

Coverage Report

Results

Number of files assessed: 19
Overall Coverage: 88.47%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
EdgeToEdgeHelper.kt app/src/main/java/org/oppia/android/app/utility/edgetoedge/EdgeToEdgeHelper.kt	96.85%	246 / 254	✅	70%
GoogleGitHubCiClient.kt scripts/src/java/org/oppia/android/scripts/release/GoogleGitHubCiClient.kt	95.38%	62 / 65	✅	70%
FindAlphaCandidate.kt scripts/src/java/org/oppia/android/scripts/release/FindAlphaCandidate.kt	78.46%	51 / 65	✅	70%
FakeGitHubCiClient.kt scripts/src/java/org/oppia/android/scripts/release/FakeGitHubCiClient.kt	100.00%	11 / 11	✅	70%
LintAnalysisReporter.kt scripts/src/java/org/oppia/android/scripts/lint/LintAnalysisReporter.kt	95.05%	422 / 444	✅	70%
AndroidLintRunner.kt scripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt	78.59%	279 / 355	✅	70%
LintModelCreator.kt scripts/src/java/org/oppia/android/scripts/lint/LintModelCreator.kt	81.82%	180 / 220	✅	70%

Exempted coverage

Files exempted from coverage

File	Exemption Reason
SurveyWelcomeDialogFragmentPresenter.kt app/src/main/java/org/oppia/android/app/survey/SurveyWelcomeDialogFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
SurveyOutroDialogFragment.kt app/src/main/java/org/oppia/android/app/survey/SurveyOutroDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
SurveyWelcomeDialogFragment.kt app/src/main/java/org/oppia/android/app/survey/SurveyWelcomeDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
SurveyOutroDialogFragmentPresenter.kt app/src/main/java/org/oppia/android/app/survey/SurveyOutroDialogFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
HintsAndSolutionDialogFragmentPresenter.kt app/src/main/java/org/oppia/android/app/hintsandsolution/HintsAndSolutionDialogFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
HintsAndSolutionDialogFragment.kt app/src/main/java/org/oppia/android/app/hintsandsolution/HintsAndSolutionDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
ConceptCardFragmentPresenter.kt app/src/main/java/org/oppia/android/app/topic/conceptcard/ConceptCardFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
ConceptCardFragment.kt app/src/main/java/org/oppia/android/app/topic/conceptcard/ConceptCardFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
GitHubCiService.kt scripts/src/java/org/oppia/android/scripts/release/remote/GitHubCiService.kt	This file is exempted from having a test file; skipping coverage check.
GitHubCiClient.kt scripts/src/java/org/oppia/android/scripts/release/GitHubCiClient.kt	This file is exempted from having a test file; skipping coverage check.
CommitListEntry.kt scripts/src/java/org/oppia/android/scripts/release/model/CommitListEntry.kt	This file is exempted from having a test file; skipping coverage check.
CheckRunsResponse.kt scripts/src/java/org/oppia/android/scripts/release/model/CheckRunsResponse.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

adhiamboperes

LGTM, thanks @ShankhanilSaha!

adhiamboperes · 2026-09-04T00:04:00Z

PTAL for owners @seanlip

oppiabot · 2026-09-04T00:05:32Z

Assigning @manas-yu for code owner reviews. Thanks!

seanlip

LGTM for OWNERS. Thanks @ShankhanilSaha!

refactor: Change minSDKVersion to 23.

25bbb34

ShankhanilSaha self-assigned this Aug 28, 2026

ShankhanilSaha requested review from a team as code owners August 28, 2026 10:21

ShankhanilSaha requested review from adhiamboperes and manas-yu August 28, 2026 10:21

oppiabot Bot assigned adhiamboperes and unassigned ShankhanilSaha Aug 28, 2026

fix: Remove obsolete tools:targetApi="23"

453f3a4

fix: coverage failure in AndroidLintRunnerTest

c47b24f

adhiamboperes requested changes Aug 30, 2026

View reviewed changes

adhiamboperes assigned ShankhanilSaha and unassigned adhiamboperes Aug 30, 2026

ref: Remove obsolete target SDK specification

27234bd

ShankhanilSaha assigned adhiamboperes and unassigned ShankhanilSaha Sep 3, 2026

adhiamboperes approved these changes Sep 4, 2026

View reviewed changes

adhiamboperes changed the title ~~Fix #6258: Deprecated Lollipop- #6350~~ Fix #6258: Deprecated Lollipop Sep 4, 2026

adhiamboperes changed the title ~~Fix #6258: Deprecated Lollipop~~ Fix #6258: Deprecate Lollipop Sep 4, 2026

adhiamboperes assigned seanlip and unassigned adhiamboperes Sep 4, 2026

oppiabot Bot assigned manas-yu Sep 4, 2026

seanlip approved these changes Sep 4, 2026

View reviewed changes

seanlip assigned ShankhanilSaha and unassigned seanlip Sep 4, 2026

adhiamboperes unassigned manas-yu Sep 8, 2026

Navigation Menu

Uh oh!

Fix #6258: Deprecate Lollipop - #6399

Fix #6258: Deprecate Lollipop#6399
ShankhanilSaha wants to merge 4 commits into
oppia:developfrom
ShankhanilSaha:deprecate-lollipop

ShankhanilSaha commented Aug 28, 2026

Uh oh!

ShankhanilSaha commented Aug 28, 2026

Uh oh!

oppiabot Bot commented Aug 28, 2026

Uh oh!

github-actions Bot commented Aug 28, 2026

Uh oh!

github-actions Bot commented Aug 30, 2026

Uh oh!

adhiamboperes left a comment

Uh oh!

ShankhanilSaha commented Aug 31, 2026

Uh oh!

github-actions Bot commented Aug 31, 2026

Uh oh!

adhiamboperes left a comment

Uh oh!

adhiamboperes commented Sep 4, 2026

Uh oh!

oppiabot Bot commented Sep 4, 2026

Uh oh!

seanlip left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ShankhanilSaha commented Aug 28, 2026

Explanation

Essential Checklist

Uh oh!

ShankhanilSaha commented Aug 28, 2026

Uh oh!

oppiabot Bot commented Aug 28, 2026

Uh oh!

github-actions Bot commented Aug 28, 2026

Coverage Report

Results

Failing coverage

Passing coverage

Uh oh!

github-actions Bot commented Aug 30, 2026

Coverage Report

Results

Passing coverage

Exempted coverage

Uh oh!

adhiamboperes left a comment

Choose a reason for hiding this comment

Uh oh!

ShankhanilSaha commented Aug 31, 2026

Uh oh!

github-actions Bot commented Aug 31, 2026

Coverage Report

Results

Passing coverage

Exempted coverage

Uh oh!

adhiamboperes left a comment

Choose a reason for hiding this comment

Uh oh!

adhiamboperes commented Sep 4, 2026

Uh oh!

oppiabot Bot commented Sep 4, 2026

Uh oh!

seanlip left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants