Skip to content

Fix #6145: Fix Admin PIN tablet layout #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samarthshukla20 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix #6145: Fix Admin PIN tablet layout #6370

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
735a690
Fix AdminAuthActivity tablet layout
Aug 22, 2026
ca3a894
Fix AdminPin tablet background layout
Aug 25, 2026
080bf48
Revert unnecessary tablet dimension changes
Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/res/layout/admin_pin_activity.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

<androidx.core.widget.NestedScrollView
android:id="@+id/scrollViewAdminPin"
android:layout_width="@dimen/admin_auth_activity_layout_width"
android:layout_width="0dp"
android:layout_height="0dp"
android:fillViewport="true"
android:overScrollMode="never"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values-sw600dp-land/dimens.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@
<dimen name="app_version_text_view_margin_end">28dp</dimen>

<!-- AdminAuthActivity -->
<dimen name="admin_auth_activity_layout_width">360dp</dimen>
<dimen name="admin_auth_activity_layout_width">0dp</dimen>
Comment thread
Neer-rn marked this conversation as resolved.
Outdated
<dimen name="admin_auth_activity_margin_start">0dp</dimen>
<dimen name="admin_auth_activity_margin_end">0dp</dimen>
<dimen name="admin_auth_activity_admin_pin_main_text_view_margin_start">0dp</dimen>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values-sw600dp-port/dimens.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@
<dimen name="completed_story_list_fragment_recyclerview_padding_bottom">112dp</dimen>

<!-- AdminAuthActivity -->
<dimen name="admin_auth_activity_layout_width">360dp</dimen>
Comment thread
Neer-rn marked this conversation as resolved.
<dimen name="admin_auth_activity_layout_width">0dp</dimen>
<dimen name="admin_auth_activity_margin_start">0dp</dimen>
<dimen name="admin_auth_activity_margin_end">0dp</dimen>
<dimen name="admin_auth_activity_admin_pin_main_text_view_margin_start">0dp</dimen>
Expand Down
Loading