Skip to content

[Bug Fix] Fix Aggregator For HAWQ Sensitivity Metric #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anzr299 wants to merge 5 commits into
base: develop
Choose a base branch
from
+9 −5
Open

[Bug Fix] Fix Aggregator For HAWQ Sensitivity Metric #4106

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbe963a
init
anzr299 Jun 18, 2026
0234de3
update refs
anzr299 Jun 18, 2026
635f434
add reset in HAWQagrgegator
anzr299 Jun 18, 2026
cf95d5c
mypy
anzr299 Jun 18, 2026
a93109e
Update collectors.py
anzr299 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/nncf/common/tensor_statistics/collectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,9 @@ def _register_reduced_input_impl(self, x: Tensor) -> None:
trace = fns.sum(fns.multiply(x, x))
# NOTE: average trace?? divide by number of diagonal elements
# TODO(dlyakhov): revise this formula as possibly it is with an error; adopted from previous HAWQ implementation
Comment thread
AlexanderDokuchaev marked this conversation as resolved.
Outdated
self._container = (self._container + trace) / x.size
# We normalize the trace by the number of elements in the tensor so that larger matrices do not dominate
# the sensitivity scores
self._container += trace / x.size
Comment thread
anzr299 marked this conversation as resolved.

def _aggregate_impl(self) -> Tensor:
return self._container * 2 / self._collected_samples
Expand Down
4 changes: 2 additions & 2 deletions tests/common/test_reducers_and_aggregators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,8 +714,8 @@ def test_aggregators_hash(self, aggregator_cls):

HAWQ_AGGREGATOR_REFERENCE_VALUES = [
([np.arange(10)], 57.0),
([np.arange(12).reshape((2, 6)), np.arange(24).reshape((4, 6))], 181.92361111111111),
([np.arange(8 * i).reshape((1, 8, i)) for i in range(1, 5)], 165.61627197265625),
([np.arange(12).reshape((2, 6)), np.arange(24).reshape((4, 6))], 222.33333333333331),
([np.arange(8 * i).reshape((1, 8, i)) for i in range(1, 5)], 300.3333333333333),
]
Comment thread
anzr299 marked this conversation as resolved.

@pytest.mark.parametrize("inputs,reference_output", HAWQ_AGGREGATOR_REFERENCE_VALUES)
Expand Down
Loading