Skip to content

Initialize variable ck_interface with NULL - #801

Open
fschueller-ifd wants to merge 1 commit into
openssl-projects:mainfrom
fschueller-ifd:init_interface_var
Open

fschueller-ifd wants to merge 1 commit into
openssl-projects:mainfrom
fschueller-ifd:init_interface_var

Conversation

@fschueller-ifd

Copy link
Copy Markdown

Description

Some pkcs11-libs cause memory-problems if the variable passed is not initialized.

Checklist

  • Code modified for feature

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages

Some pkcs11-libs cause memory-problems if not initialized.

Signed-off-by: fschueller-ifd <f.schueller@infodas.de>

@Jakuje Jakuje left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code comment you wrote should be in commit message. Otherwise looks good

@fschueller-ifd

Copy link
Copy Markdown
Author

I think the code comment you wrote should be in commit message. Otherwise looks good

Sorry for that, actually I tried to C&P teh comment into the commit, but there where to many new interfaces an external obstacles in the way of getting the easy fix into github...

@simo5

simo5 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

yup, please drop the comment which will make the style check failure go away as well.

@simo5

simo5 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

@fschueller-ifd if you do not know how to amend the commit let me know and I'll do it for you before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants