OCPEDGE-2933: feat: add MAC-keyed FC TNF IPI install weekly lanes - #83799
OCPEDGE-2933: feat: add MAC-keyed FC TNF IPI install weekly lanes#83799fracappa wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughThe change adds a MAC-address-based two-node fencing workflow and schedules it as a 168-hour periodic test in the nightly 5.0 and 5.1 release configurations. ChangesMAC fencing CI coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds CI coverage for MAC-keyed fencing installation lanes without any supplied evidence of an actionable merge-blocking risk; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant PeriodicTestJob
participant FencingWorkflow
participant PreSteps
participant IpiTest
participant PostSteps
PeriodicTestJob->>FencingWorkflow: starts baremetalds-two-node-fencing-mac
FencingWorkflow->>PreSteps: runs pre chain
FencingWorkflow->>IpiTest: runs baremetalds-ipi-test
FencingWorkflow->>PostSteps: runs post chain
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS: The pull request adds CI configuration, generated periodic jobs, ownership metadata, and a workflow definition. The changed lines contain no Ginkgo test-title constructs such as Full details: Test Structure And QualityExplanation PASS: The pull request changes only CI configuration, generated periodic-job YAML, OWNERS metadata, and a declarative workflow. The exact commit diff adds no Ginkgo test code or Full details: Microshift Test CompatibilityExplanation PASS — The pull request adds CI and workflow YAML only. The diff contains no Go files and no new Ginkgo declarations such as Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS — The pull request adds CI configuration and a bare-metal workflow only. The parent-to-HEAD diff contains YAML, JSON, OWNERS, and generated Prow job changes; it adds no Go or other test source files and no Ginkgo Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request adds CI release entries, generated Prow periodic jobs, ownership metadata, and a CI-operator workflow. It does not add or modify deployment manifests, operator code, or controllers. The new workflow only configures a two-node test installation ( Full details: Ote Binary Stdout ContractExplanation PASS — The pull request changes only CI YAML, JSON metadata, and OWNERS files. It adds no OTE binary source, main or suite setup code, logging configuration, or stdout write. The new workflow reuses the existing Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request adds CI configuration and a step-registry workflow only. The parent-to-HEAD diff adds no Go files, Ginkgo declarations ( Full details: No-Weak-CryptoExplanation PASS: The commit adds CI scheduling, ownership metadata, and a workflow configuration. Its only credential-related setting is Full details: Container-PrivilegesExplanation PASS: The pull request adds no Full details: No-Sensitive-Data-In-LogsExplanation PASS. The commit adds CI configuration and a workflow only. It adds no logging command, log format, literal password, token, API key, email, session ID, hostname, or customer data. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fracappa The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fracappa
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@fracappa: This pull request references OCPEDGE-2933 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.1.0." or "openshift-5.1.0.", but it targets "openshift-5.0" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@fracappa: This pull request references OCPEDGE-2933 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse |
|
@fracappa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@fracappa: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
919eb0c to
19f4c7f
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@fracappa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2 participants
MAC-based fencing credentials has been recently introduced in Openshift.
This PR introduces a CI lane to validate this new installation method in the IPI path.
This PR depends on: openshift-metal3/dev-scripts#1916
Summary by CodeRabbit
Adds weekly OpenShift CI lanes for two-node fencing with MAC-based credentials.
baremetalds-two-node-fencing-macworkflow for TNF IPI installations.FENCING_CREDENTIAL_IDENTIFIER=macAddress.nightly-5.0andnightly-5.1periodic jobs on the Equinix edge-enablement profile.