Skip to content

GIE-507: [release-0.3] update observability task prompts to request metric names and PromQL queries#276

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-0.3from
openshift-cherrypick-robot:cherry-pick-274-to-release-0.3
Apr 28, 2026
Merged

GIE-507: [release-0.3] update observability task prompts to request metric names and PromQL queries#276
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-0.3from
openshift-cherrypick-robot:cherry-pick-274-to-release-0.3

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #274

/assign slashpai

…PromQL queries

The observability eval tasks were failing because agents correctly answered
questions but summarized results in natural language without restating the
Prometheus metric name. The llmJudge contains assertions check the agent's
response text, not tool call arguments, so correct answers were marked as
failures.

Update 15 task prompts to explicitly ask the agent to include the metric
name and PromQL query used. This ensures the metric name appears in the
response for the judge to verify, while keeping the contains assertions
strict and non-overlapping with prompt text.

Signed-off-by: Jayapriya Pai <janantha@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 27, 2026

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: GIE-507

Details

In response to this:

This is an automated cherry-pick of #274

/assign slashpai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 19495c6c-0b58-4848-88e6-bc7cfce23338

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from Cali0707 and matzew April 27, 2026 18:49
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 27, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@slashpai
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2026
@slashpai
Copy link
Copy Markdown
Member

@Cali0707 for backport approval

@matzew
Copy link
Copy Markdown
Member

matzew commented Apr 28, 2026

/override "Red Hat Konflux / openshift-mcp-server-release-03-on-pull-request"

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 28, 2026

@matzew: Overrode contexts on behalf of matzew: Red Hat Konflux / openshift-mcp-server-release-03-on-pull-request

Details

In response to this:

/override "Red Hat Konflux / openshift-mcp-server-release-03-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
@slashpai
Copy link
Copy Markdown
Member

slashpai commented Apr 28, 2026

/retitle GIE-507: [release-0.3] update observability task prompts to request metric names and PromQL queries

@openshift-ci openshift-ci Bot changed the title [release-0.3] GIE-507: update observability task prompts to request metric names and PromQL queries GIE-507: [release-0.3] update observability task prompts to request metric names and PromQL queries Apr 28, 2026
@slashpai
Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2026

@slashpai: This pull request references GIE-507 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit de5dfc5 into openshift:release-0.3 Apr 28, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants