GIE-504: Use rhobs/obs-mcp toolset for Prometheus/Alertmanager (replaces observability mcp)#226
Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom Apr 20, 2026
Conversation
Member
saswatamcode
commented
Apr 14, 2026
saswatamcode
commented
|
Important Review skippedToo many files! This PR contains 295 files, which is 145 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (295)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
matzew
reviewed
Apr 14, 2026
matzew
reviewed
Apr 14, 2026
Member
|
We have no evals / mcpchecker here - but I saw this based on discussions on slack CC @Cali0707 |
matzew
reviewed
Apr 14, 2026
Member
|
One of the things to have in mind when using the go modules, instead of directly prviding tools there is that it might be easier to miss tool renaming. E.g. the old version used to have: |
…vability mcp) Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
matzew
reviewed
Apr 16, 2026
| github.com/miekg/dns v1.1.68 | ||
| github.com/modelcontextprotocol/go-sdk v1.5.0 | ||
| github.com/prometheus/client_golang v1.23.2 | ||
| github.com/rhobs/obs-mcp v0.1.0-rc.1.0.20260414161157-6067303e23c9 |
Member
There was a problem hiding this comment.
Any idea when the actual release will be out ? 😅
Member
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Member
Author
|
Thanks! Also pinned the module to latest release rc |
|
@saswatamcode no evals for testing the obs-mcp toolset? |
Member
Author
|
@mvinkler evals are here rhobs/obs-mcp#34 |
|
@matzew is there any convention regarding toolset naming? This one is now called obs-mcp, while no other has -mcp suffix. |
Member
|
Ah. Good catch
the actual name of the tool should not have -mcp in its name.
The go module however could
Sent from Gmail Mobile
…On Thu 16. Apr 2026 at 11:48, Michal Vinkler ***@***.***> wrote:
*mvinkler* left a comment (openshift/openshift-mcp-server#226)
<#226 (comment)>
@matzew <https://github.com/matzew> is there any convention regarding
toolset naming? This one is now called obs-mcp, while no other has -mcp
suffix.
—
Reply to this email directly, view it on GitHub
<#226 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTVPSKNV666D4U24UWD4WCT2FAVCNFSM6AAAAACXYNSKCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DENJZGAZDCNZRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
saswatamcode
added a commit
to saswatamcode/obs-mcp
that referenced
this pull request
Apr 16, 2026
As per conventions in openshift-mcp-server, we need to rename the toolset to something more suitable as per openshift/openshift-mcp-server#226 (comment) Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
mvinkler
reviewed
Apr 16, 2026
| - `filter` (`string`) - Optional filter using Alertmanager filter syntax. Examples: 'alertname=Watchdog', 'severity=critical', 'namespace=openshift-monitoring' | ||
| - `inhibited` (`boolean`) - Include inhibited alerts in the results. Default: false | ||
| - `silenced` (`boolean`) - Include silenced alerts in the results. Default: false | ||
| <summary>obs-mcp</summary> |
There was a problem hiding this comment.
This should be also renamed back to observability?
|
Due to unified testing approach, I need the evals to be also in this repo. At least in the release-0.3 branch. |
Member
would be good if those evals were part of this repo. CC @Cali0707 |
slashpai
reviewed
Apr 16, 2026
| | helm | Tools for managing Helm charts and releases | | | ||
| | kcp | Manage kcp workspaces and multi-tenancy features | | | ||
| | kubevirt | KubeVirt virtual machine management tools, check the [KubeVirt documentation](https://github.com/containers/kubernetes-mcp-server/blob/main/docs/kubevirt.md) for more details. | | | ||
| | obs-mcp | Toolset for querying Prometheus and Alertmanager endpoints in efficient ways. | | |
Member
There was a problem hiding this comment.
Should we mention Thanos also?
|
From https://github.com/rhobs/obs-mcp/tree/main: obs-mcp has many new flags, for example: These flags will be merged to the openshift-mcp-server? What is their description? |
saswatamcode
added a commit
to saswatamcode/obs-mcp
that referenced
this pull request
Apr 16, 2026
As per conventions in openshift-mcp-server, we need to rename the toolset to something more suitable as per openshift/openshift-mcp-server#226 (comment) Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
|
@mvinkler I don't think we need to merge the flags into openshift-mcp-server. Would you agree @saswatamcode? |
Member
Author
|
I don't think we are merging any flags here, the same is only exposed through toml config |
Cali0707
approved these changes
Apr 20, 2026
Cali0707
left a comment
Cali0707
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Lets make sure we get evals in soon so that we can test and release this toolset as TP instead of DP
|
@matzew can you backport this to the release branch? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, saswatamcode The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
saswatamcode
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@saswatamcode: This pull request references GIE-504 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Member
|
/override "Konflux kflux-prd-rh02 / openshift-mcp-server-on-pull-request" |
|
@matzew: Overrode contexts on behalf of matzew: Konflux kflux-prd-rh02 / openshift-mcp-server-on-pull-request DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
|
@nader-ziada: nader-ziada unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@saswatamcode: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit 88d919b
into
openshift:main
10 of 11 checks passed
|
/cherry-pick release-0.3 |
|
@tremes: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked. Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.