Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ RUN go mod download
COPY . .
RUN make build

FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1776833838
FROM registry.access.redhat.com/ubi9/ubi-minimal:1780379098

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Red Hat images should use floating tags, not pinned tags.

The coding guidelines specify that Red Hat images should use floating tags so that Red Hat can manage updates automatically. However, this Dockerfile uses a pinned tag (1780379098). Consider using a floating tag like :9 or :latest instead to align with the guideline and allow Red Hat to manage security updates.

As per coding guidelines: "Red Hat images: use floating tags (Red Hat manages updates); non-RH images: pin by digest"

🔄 Proposed fix to use floating tag
-FROM registry.access.redhat.com/ubi9/ubi-minimal:1780379098
+FROM registry.access.redhat.com/ubi9/ubi-minimal:9
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
FROM registry.access.redhat.com/ubi9/ubi-minimal:1780379098
FROM registry.access.redhat.com/ubi9/ubi-minimal:9
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@build/Dockerfile` at line 10, Replace the pinned Red Hat base image tag in
the Dockerfile's FROM instruction (currently using
registry.access.redhat.com/ubi9/ubi-minimal:1780379098) with a floating tag such
as :9 or :latest so Red Hat can manage updates automatically; update the FROM
line to reference registry.access.redhat.com/ubi9/ubi-minimal:<floating-tag> and
commit the change.


LABEL io.openshift.managed.name="ocm-agent" \
io.openshift.managed.description="Agent to interact with OCM on managed clusters"
Expand Down