Skip to content

ROSA-745: boilerplate-update and enable MintMaker gomod#487

Closed
MitaliBhalla wants to merge 1 commit into
openshift:masterfrom
MitaliBhalla:rosa-745-mintmaker-gomod
Closed

ROSA-745: boilerplate-update and enable MintMaker gomod#487
MitaliBhalla wants to merge 1 commit into
openshift:masterfrom
MitaliBhalla:rosa-745-mintmaker-gomod

Conversation

@MitaliBhalla

@MitaliBhalla MitaliBhalla commented Jun 12, 2026

Copy link
Copy Markdown

Summary

  • make boilerplate-update (includes boilerplate #748 dependabot template)
  • .github/renovate.jsonenabledManagers: [tekton, gomod] for MintMaker gomod PRs

Test plan

  • CI green

Jira: ROSA-745

Summary by CodeRabbit

  • Chores
    • Updated dependency automation settings to support additional package and pipeline management formats.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a8af6252-1491-455e-b96e-813a244902a7

📥 Commits

Reviewing files that changed from the base of the PR and between 098d4a0 and 6812dd2.

📒 Files selected for processing (1)
  • .github/renovate.json
✅ Files skipped from review due to trivial changes (1)
  • .github/renovate.json

Walkthrough

Adds an enabledManagers configuration entry to .github/renovate.json, specifying tekton and gomod as enabled Renovate managers.

Changes

Renovate Configuration Update

Layer / File(s) Summary
Enable Renovate managers
.github/renovate.json
Adds an enabledManagers array listing tekton and gomod to the Renovate configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning The new osde2e Ginkgo suite downloads CRDs/manifests from raw.githubusercontent.com and talks to Route53/AWS, so it needs public connectivity. Mirror external manifests/images or gate this suite for disconnected/IPv6 clusters; add an IPv6 disconnected CI run to validate as appropriate.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: boilerplate updates and enabling the MintMaker gomod manager.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The only Ginkgo specs use static strings (e.g. "Certman Operator"); no titles interpolate pod/namespace/UUID/date values or other run-dependent data.
Test Structure And Quality ✅ Passed PR only updates .github/renovate.json; no Ginkgo or test files were changed, so the test-quality review is not applicable.
Microshift Test Compatibility ✅ Passed Only .github/renovate.json changed; no Ginkgo e2e tests or MicroShift-unsupported APIs/features were added or modified.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The only new Ginkgo e2e specs are API/pod-level checks; I found no multi-node, HA, drain, scaling, or node-topology assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed Only Renovate/boilerplate metadata changed; no added anti-affinity, node selectors, tolerations, or topology spread constraints.
Ote Binary Stdout Contract ✅ Passed Only .github/renovate.json changed; no Go entrypoints, suite setup, or stdout-writing code was modified, so the OTE stdout contract is unaffected.
No-Weak-Crypto ✅ Passed The PR only adjusts Renovate/boilerplate files; no added code uses weak ciphers/hashes or non-constant-time secret comparisons.
Container-Privileges ✅ Passed PR only updates .github/renovate.json; no privileged/hostNetwork/hostPID/hostIPC or allowPrivilegeEscalation:true changes were introduced.
No-Sensitive-Data-In-Logs ✅ Passed PR changes only .github/renovate.json; diff adds enabledManagers and no logging or sensitive-data strings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown

@MitaliBhalla: This pull request references ROSA-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the initiative to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • make boilerplate-update (includes boilerplate #748 dependabot template)
  • .github/renovate.jsonenabledManagers: [tekton, gomod] for MintMaker gomod PRs

Test plan

  • CI green

Jira: ROSA-745

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from charlesgong and hbhushan3 June 12, 2026 08:17
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MitaliBhalla
Once this PR has been reviewed and has the lgtm label, please assign theautoroboto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.14%. Comparing base (09ed286) to head (098d4a0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #487   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files          29       29           
  Lines        2170     2170           
=======================================
  Hits         1240     1240           
  Misses        812      812           
  Partials      118      118           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MitaliBhalla MitaliBhalla force-pushed the rosa-745-mintmaker-gomod branch from a4cf641 to 098d4a0 Compare June 12, 2026 08:52
Add enabledManagers tekton/gomod in renovate.json; boilerplate-update
when no equivalent upstream PR is already open.
@MitaliBhalla MitaliBhalla force-pushed the rosa-745-mintmaker-gomod branch from 098d4a0 to 6812dd2 Compare July 1, 2026 06:48
@MitaliBhalla

MitaliBhalla commented Jul 1, 2026

Copy link
Copy Markdown
Author

Refreshed branch: minimal ROSA-745 diff (renovate enabledManagers; boilerplate-update only if no parallel boilerplate PR).

@MitaliBhalla

MitaliBhalla commented Jul 1, 2026

Copy link
Copy Markdown
Author

Closing ROSA-745 fleet PR — superseded by corrected rollout plan.

Problem: these PRs bundled redundant repo-root enabledManagers (already inherited via extends openshift/boilerplate #748), unnecessary boilerplate churn, and PKO/fixture noise. A fresh minimal PR per repo will follow the correct model.

Jira: ROSA-745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants