OCPBUGS-90570: Reject non-empty checksum for OCI images

[mabulgu]

OCPBUGS-84305: Reject non-empty checksum for OCI images

Cherry-pick of upstream metal3-io#3186 to release-4.22.

GetChecksum() made checksums optional for OCI images but never rejected a non-empty checksum. This causes the webhook to accept invalid configurations where both oci:// scheme and a checksum are provided, leading to confusing provisioning failures.

This fix:

• Rejects spec.image.checksum when an oci:// URL is used, returning a clear error message
• Moves the OCI check before the live-iso early return to prevent bypassing the validation with oci:// + live-iso + non-empty checksum

[openshift-ci-robot]

@mabulgu: This pull request references Jira Issue OCPBUGS-90570, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set
• expected dependent Jira Issue OCPBUGS-84305 to target a version in 5.0.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-84305: Reject non-empty checksum for OCI images

Cherry-pick of upstream metal3-io#3186 to release-4.22.

GetChecksum() made checksums optional for OCI images but never rejected a non-empty checksum. This causes the webhook to accept invalid configurations where both oci:// scheme and a checksum are provided, leading to confusing provisioning failures.

This fix:

• Rejects spec.image.checksum when an oci:// URL is used, returning a clear error message
• Moves the OCI check before the live-iso early return to prevent bypassing the validation with oci:// + live-iso + non-empty checksum

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 152e7c9a-a788-4d3b-ab6c-cfe3273565ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mabulgu
Once this PR has been reviewed and has the lgtm label, please assign honza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mabulgu]

/jira refresh

[openshift-ci-robot]

@mabulgu: This pull request references Jira Issue OCPBUGS-90570, which is invalid:

• expected dependent Jira Issue OCPBUGS-84305 to target a version in 5.0.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mabulgu]

/jira refresh

[openshift-ci-robot]

@mabulgu: This pull request references Jira Issue OCPBUGS-90570, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-84305 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-84305 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
• bug has dependents

Requesting review from QA contact:
/cc @sgoveas

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mabulgu]

/retest

[openshift-ci]

@mabulgu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-deps	b552b74	link	true	/test verify-deps
ci/prow/vendor	b552b74	link	true	/test vendor

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.