Skip to content

OCPBUGS-83866: Include image URL and checksum in provisioning error message #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mabulgu wants to merge 1 commit into
base: release-4.22
Choose a base branch
from
+3 −2
Open

OCPBUGS-83866: Include image URL and checksum in provisioning error message #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/provisioner/ironic/ironic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1275,7 +1275,8 @@ func (p *ironicProvisioner) Provision(ctx context.Context, data provisioner.Prov
return retryAfterDelay(0)
}
p.log.Info("found error", "msg", ironicNode.LastError)
return operationFailed("Image provisioning failed: " + ironicNode.LastError)
checksum, _, _ := data.Image.GetChecksum()
return operationFailed(fmt.Sprintf("Image provisioning failed (url: %s, checksum: %s): %s", data.Image.URL, checksum, ironicNode.LastError))
}
p.log.Info("recovering from previous failure")
if provResult, err = p.setUpForProvisioning(ctx, ironicNode, data); err != nil || provResult.Dirty || provResult.ErrorMessage != "" {
Expand Down
2 changes: 1 addition & 1 deletion pkg/provisioner/ironic/provision_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func TestProvision(t *testing.T) {
}),
expectedRequestAfter: 0,
expectedDirty: false,
expectedErrorMessage: "Image provisioning failed: no work today",
expectedErrorMessage: "Image provisioning failed (url: http://test-image, checksum: abcd): no work today",
},
{
name: "cleanFail state",
Expand Down