Skip to content

Bahesab calendar second four month#40

Merged
sepandhaghighi merged 7 commits intoopenscilab:devfrom
Amirsaeed7:bahesab-calendar-second-four-month
Mar 26, 2026
Merged

Bahesab calendar second four month#40
sepandhaghighi merged 7 commits intoopenscilab:devfrom
Amirsaeed7:bahesab-calendar-second-four-month

Conversation

@Amirsaeed7
Copy link
Copy Markdown
Contributor

In this PR i added the events of second four months Mordad, Shahrivar, Mehr and Aban events from the Bahesab Calendar
here are couple of questions about this PR:

1-August 1st -> "روز جهانی شیر مادر" and "آغار هفته جهانی شیردهی" is both of these events needed?

2-According to Bahesab calendar "روز جهانی دریانوردی" is on September 30th but according to our last resource it was mentioned on the September 25th and based on my research that's the correct date should we mention it on 30th too?

3-According to Bahesab calendar "روز جهانی کودک " is on October 8th but according to our last resource it was mentioned on the November 20th and based on my research that's the correct date should we mention it on 8th too?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (5836a93) to head (2913c40).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #40   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files           7        7           
  Lines         109      109           
  Branches       25       25           
=======================================
  Hits          106      106           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi
Copy link
Copy Markdown
Member

1-August 1st -> "روز جهانی شیر مادر" and "آغار هفته جهانی شیردهی" is both of these events needed?

2-According to Bahesab calendar "روز جهانی دریانوردی" is on September 30th but according to our last resource it was mentioned on the September 25th and based on my research that's the correct date should we mention it on 30th too?

3-According to Bahesab calendar "روز جهانی کودک " is on October 8th but according to our last resource it was mentioned on the November 20th and based on my research that's the correct date should we mention it on 8th too?

  1. Only keep "آغار هفته جهانی شیردهی"
  2. No
  3. I think Bahesab made a mistake and that is 16 Mehr, Iran's Children's Day, not International Children's Day.

@Amirsaeed7
Copy link
Copy Markdown
Contributor Author

1-August 1st -> "روز جهانی شیر مادر" and "آغار هفته جهانی شیردهی" is both of these events needed?
2-According to Bahesab calendar "روز جهانی دریانوردی" is on September 30th but according to our last resource it was mentioned on the September 25th and based on my research that's the correct date should we mention it on 30th too?
3-According to Bahesab calendar "روز جهانی کودک " is on October 8th but according to our last resource it was mentioned on the November 20th and based on my research that's the correct date should we mention it on 8th too?

  1. Only keep "آغار هفته جهانی شیردهی"
  2. No
  3. I think Bahesab made a mistake and that is 16 Mehr, Iran's Children's Day, not International Children's Day.

Thank you the changes were made.

@Amirsaeed7
Copy link
Copy Markdown
Contributor Author

Hi @sadrasabouri , I hope you're doing well
If you still don't have access to Bahesab Calendar let me know to provide you with the html files.

@sadrasabouri
Copy link
Copy Markdown
Member

Hi @sadrasabouri , I hope you're doing well If you still don't have access to Bahesab Calendar let me know to provide you with the html files.

Hey, thanks for checking. I just checked now and I have access. I will review in coming days.

Copy link
Copy Markdown
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. I left some minor comments.

Copy link
Copy Markdown
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@sepandhaghighi
Copy link
Copy Markdown
Member

Looks good to me now.

I will complete my review within the next 24 hours ⌚

Copy link
Copy Markdown
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi sepandhaghighi merged commit 0291966 into openscilab:dev Mar 26, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants