Skip to content

Upgrade to version 0.31 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElviaBth wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Upgrade to version 0.31 #132

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
375cde8
upgrade to version 0.31
ElviaBth Feb 9, 2026
1b51a70
replace valuator for evaluator
ElviaBth Feb 10, 2026
20b50c8
fix lint
ElviaBth Feb 10, 2026
a75440b
add decidim- initiatives gem
ElviaBth Feb 10, 2026
c001990
remane spec
ElviaBth Feb 10, 2026
2eb73f8
replace term valuator
ElviaBth Feb 10, 2026
54d1a2f
fix actions dropdown
ElviaBth Feb 10, 2026
31bb5ae
fix controllers specs
ElviaBth Feb 11, 2026
09b7a6a
fix some specs
ElviaBth Feb 11, 2026
dcea119
update bulk_actions views
ElviaBth Feb 13, 2026
3c4589a
update component.rb
ElviaBth Feb 16, 2026
9a0c7e2
update evaluation assigments controller
ElviaBth Feb 16, 2026
c184028
fix some specs
ElviaBth Feb 16, 2026
231876f
fix some controllers spec
ElviaBth Feb 17, 2026
e32f7a5
fix pdf-viewer specs
ElviaBth Feb 19, 2026
be08919
fix filters specs
ElviaBth Feb 19, 2026
8972a8e
apply suggested changes
ElviaBth Mar 3, 2026
1189ce7
rename migration
ElviaBth Mar 3, 2026
f245b12
add evaluation assignment presenter
ElviaBth Mar 20, 2026
9b2bc96
normalize --locales
ElviaBth Mar 20, 2026
5d8bde9
remove import initLanguageChangeSelect
ElviaBth Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:

env:
CI: "true"
RUBY_VERSION: 3.2.6
NODE_VERSION: 18.17.1
RUBY_VERSION: 3.3.10
NODE_VERSION: 22.14.0

jobs:
lint-report:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ on:
pull_request:

env:
RUBY_VERSION: 3.2.6
NODE_VERSION: 18.17.1
RUBY_VERSION: 3.3.10
NODE_VERSION: 22.14.0
DISABLE_SPRING: 1
CI: "true"

Expand Down Expand Up @@ -38,8 +38,8 @@ jobs:
with:
fetch-depth: 1

- name: Install imagemagick and wkhtmltopdf
run: sudo apt install imagemagick wkhtmltopdf
- name: Install imagemagick
run: sudo apt install imagemagick

@coderabbitai coderabbitai Bot Mar 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use non-interactive install flags for CI package install.

Line 42 may fail or block in CI because apt can prompt for confirmation. Prefer apt-get with -y (and update package index first).

Suggested fix 
-      - name: Install imagemagick
-        run: sudo apt install imagemagick
+      - name: Install imagemagick
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y imagemagick
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run: sudo apt install imagemagick
run: |
sudo apt-get update
sudo apt-get install -y imagemagick
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/test.yml at line 42, Replace the interactive apt install
command in the workflow step (the run line currently using "sudo apt install
imagemagick") with a non-interactive sequence: update the package index and use
apt-get with -y and noninteractive flags (for example, run "sudo apt-get update
&& sudo DEBIAN_FRONTEND=noninteractive apt-get install -y
--no-install-recommends imagemagick") to avoid CI prompts and reduce unnecessary
recommended packages.


- uses: ruby/setup-ruby@v1
with:
Expand Down
11 changes: 6 additions & 5 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
inherit_from:
- https://raw.githubusercontent.com/decidim/decidim/release/0.29-stable/.rubocop.yml
inherit_gem:
decidim-dev: rubocop-decidim.yml

AllCops:
Exclude:
- 'db/**/*.rb'
- 'vendor/**/*'
- "spec/decidim_dummy_app*/**/*"
- "development_app/**/*"
- "node_modules/**/*"

RSpec/DescribeClass:
Exclude:
- 'spec/system/**/*'
- 'spec/i18n_spec.rb'
- spec/i18n_spec.rb
- "spec/system/**/*"
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.6
3.3.10
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ gem "puma", ">= 6.3.1"
group :development, :test do
gem "byebug", "~> 11.0", platform: :mri
gem "decidim-dev", DECIDIM_VERSION
gem "decidim-initiatives", DECIDIM_VERSION
Comment thread
ElviaBth marked this conversation as resolved.
end

group :development do
Expand Down
Loading