Skip to content

fix(patches): include preview-props.json in loadManifest glob for Next.js 16.4 #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chargome wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(patches): include preview-props.json in loadManifest glob for Next.js 16.4 #1356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/fix-preview-props-manifest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
"@opennextjs/cloudflare": patch
---

fix(patches): include `preview-props.json` in loadManifest build-time inlining

Next.js 16.4 moved preview props out of `prerender-manifest.json` into a standalone
`.next/server/preview-props.json` (`PREVIEW_PROPS_MANIFEST`), loaded unconditionally by
`NextNodeServer.getPreviewProps()` from the `Server` constructor. The file exists in the build
output but wasn't matched by the glob pattern `*-manifest.json`, so the patched `loadManifest()`
threw at runtime and every dynamic route returned a 500.

It is inlined rather than falling back to `{}` because it holds the actual draft-mode
id and signing/encryption keys.
7 changes: 6 additions & 1 deletion packages/cloudflare/src/cli/build/patches/plugins/load-manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,13 @@ async function getLoadManifestRule(buildOpts: BuildOptions) {
const baseDir = join(outputDir, "server-functions/default", getPackagePath(buildOpts));
const dotNextDir = join(baseDir, ".next");

// Most server manifests are named `*-manifest.json`, but a few are not:
// `required-server-files.json`, `prefetch-hints.json` (Next 16.2+) and
// `server/preview-props.json` (Next 16.4+, previously inlined in the
// prerender manifest). They are loaded unconditionally by `NextNodeServer`,
// so they must be inlined rather than falling back to `{}`.
const manifests = await glob(
join(dotNextDir, "**/{*-manifest,required-server-files,prefetch-hints}.json"),
join(dotNextDir, "**/{*-manifest,required-server-files,prefetch-hints,preview-props}.json"),
{
windowsPathsNoEscape: true,
}
Expand Down